https://github.com/razvanlupusoru approved this pull request.

Looks great to me!

Regarding the testing, one aspect I noticed, is that all of the tests exercise 
with "seq" only. I wanted to point out that omission of "seq" when the user 
does not specify it is important (and your current implementation seems correct 
since it only emits this in explicit cases). Lack of seq (or any other explicit 
parallelism marking) is useful to ensure that compiler can automatically 
determine parallelism.

https://github.com/llvm/llvm-project/pull/170207
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to