@jyknight I've removed the check on nostdinc. AFAIK, I've addressed all the feedback which I've received on the patch, is it OK to commit? --Melanie
-----Original Message----- From: James Y Knight via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Monday, July 10, 2017 11:57 AM To: Blower, Melanie <melanie.blo...@intel.com>; zhangsheng...@huawei.com; olivier...@gmail.com; kalinichev.s...@gmail.com; kf...@kde.org; m...@milianw.de; Keane, Erich <erich.ke...@intel.com>; hahnf...@itc.rwth-aachen.de; mgo...@gentoo.org; fedor.serg...@oracle.com; rich...@metafoo.co.uk; renato.go...@linaro.org Cc: jykni...@google.com; ibiryu...@google.com; cfe-commits@lists.llvm.org; kli...@google.com; simon.dar...@imgtec.com; anastasia.stul...@arm.com; arichardson....@gmail.com Subject: [PATCH] D34158: For standards compatibility, preinclude <stdc-predef.h> if the file is available jyknight added a comment. This version is still disabling upon -nostdinc, which doesn't make sense to me. You didn't remove that, nor respond explaining why you think it does make sense? https://reviews.llvm.org/D34158 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
