================
@@ -1495,6 +1495,13 @@ void Sema::ActOnEndOfTranslationUnit() {
     Consumer.CompleteExternalDeclaration(D);
   }
 
+  // Visit all pending #pragma export.
+  for (auto &Iter : PendingExportedNames) {
----------------
erichkeane wrote:

We don't use `auto` when the type is not obvious from the context.  We also 
have an exception for 'iterators that are out of hand'.

In this case, it is, I see, a `DenseMapPtr<IdentifierInfo*, SymbolLabel>` 
(which took a SHOCKING amount of work to figure out, which is exactly why we 
don't want 'auto' here).  

In your pair of suggestions, the 1st would be acceptable, the 2nd would not..

https://github.com/llvm/llvm-project/pull/141671
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to