github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r origin/main...HEAD
clang/test/Misc/pypass-plugin-entrypoints.py
clang/test/Misc/pypass-plugin-params.py clang/test/Misc/pypass-plugin-repl.py
lld/test/ELF/lto/pypass-plugin-entrypoints.py
lld/test/ELF/lto/pypass-plugin-pipeline-parsing.py
llvm/test/tools/plugins-shlib/Inputs/mymod.py
llvm/test/tools/plugins-shlib/pypass-functions.py
llvm/test/tools/plugins-shlib/pypass.py clang/test/lit.cfg.py
lld/test/lit.cfg.py
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- clang/test/Misc/pypass-plugin-entrypoints.py 2025-12-05
14:04:00.000000 +0000
+++ clang/test/Misc/pypass-plugin-entrypoints.py 2025-12-08
09:57:14.595643 +0000
@@ -67,50 +67,61 @@
# EP-LTO-THIN: ScalarOptimizerLateEPCallback
# EP-LTO-THIN: OptimizerEarlyEPCallback
# EP-LTO-THIN-NOT: Vectorizer{{.*}}EPCallback
# EP-LTO-THIN: OptimizerLastEPCallback
+
def registerPipelineStartEPCallback():
- """ Module pass at the start of the pipeline """
+ """Module pass at the start of the pipeline"""
return True
+
def registerPipelineEarlySimplificationEPCallback():
- """ Module pass after basic simplification of input IR """
+ """Module pass after basic simplification of input IR"""
return True
+
def registerOptimizerEarlyEPCallback():
- """ Module pass before the function optimization pipeline """
+ """Module pass before the function optimization pipeline"""
return True
+
def registerOptimizerLastEPCallback():
- """ Module pass after the function optimization pipeline """
+ """Module pass after the function optimization pipeline"""
return True
+
def registerPeepholeEPCallback():
- """ Function pass after each instance of the instruction combiner pass """
+ """Function pass after each instance of the instruction combiner pass"""
return True
+
def registerScalarOptimizerLateEPCallback():
- """ Function pass after most of the main optimizations, but before the last
- cleanup-ish optimizations"""
+ """Function pass after most of the main optimizations, but before the last
+ cleanup-ish optimizations"""
return True
+
def registerVectorizerStartEPCallback():
- """ Function pass before the vectorizer and other highly target specific
- optimization passes are executed. """
+ """Function pass before the vectorizer and other highly target specific
+ optimization passes are executed."""
return True
+
def registerVectorizerEndEPCallback():
- """ Function pass after the vectorizer and other highly target specific
- optimization passes are executed. """
+ """Function pass after the vectorizer and other highly target specific
+ optimization passes are executed."""
return True
+
def registerFullLinkTimeOptimizationEarlyEPCallback():
- """ Module pass at the start of the full LTO pipeline """
+ """Module pass at the start of the full LTO pipeline"""
return True
+
def registerFullLinkTimeOptimizationLastEPCallback():
- """ Module pass at the end of the full LTO pipeline """
+ """Module pass at the end of the full LTO pipeline"""
return True
+
def run(input, ctx, stage):
print(f"0x{input:016x} {stage}")
--- clang/test/Misc/pypass-plugin-params.py 2025-12-05 14:04:00.000000 +0000
+++ clang/test/Misc/pypass-plugin-params.py 2025-12-08 09:57:14.603822 +0000
@@ -18,11 +18,13 @@
# RUN: -Xclang -fdebug-pass-manager \
# RUN: -o /dev/null -S -emit-llvm %S/Inputs/pypass-plugin.c 2>&1 |
FileCheck %s
#
# CHECK: Running pass: PyPass
+
def registerPipelineEarlySimplificationEPCallback():
- """ Module pass after basic simplification of input IR """
+ """Module pass after basic simplification of input IR"""
return True
+
def run(input, ctx, stage):
print(f"0x{input:016x} {stage}")
--- clang/test/Misc/pypass-plugin-repl.py 2025-12-05 14:04:00.000000 +0000
+++ clang/test/Misc/pypass-plugin-repl.py 2025-12-08 09:57:14.611076 +0000
@@ -5,11 +5,13 @@
# RUN: env LLVM_PYPASS_DYLIB=%libpython \
# RUN: clang-repl -Xcc -fpass-plugin=%plugindir/pypass-plugin%pluginext |
FileCheck %s
#
# CHECK: PipelineEarlySimplificationEPCallback
+
def registerPipelineEarlySimplificationEPCallback():
- """ Module pass after basic simplification of input IR """
+ """Module pass after basic simplification of input IR"""
return True
+
def run(input, ctx, stage):
print(f"0x{input:016x} {stage}")
--- lld/test/ELF/lto/pypass-plugin-entrypoints.py 2025-12-05
14:04:00.000000 +0000
+++ lld/test/ELF/lto/pypass-plugin-entrypoints.py 2025-12-08
09:57:14.737697 +0000
@@ -40,50 +40,61 @@
# THIN: OptimizerEarlyEPCallback
# THIN: VectorizerStartEPCallback
# THIN: VectorizerEndEPCallback
# THIN: OptimizerLastEPCallback
+
def registerPipelineStartEPCallback():
- """ Module pass at the start of the pipeline """
+ """Module pass at the start of the pipeline"""
return True
+
def registerPipelineEarlySimplificationEPCallback():
- """ Module pass after basic simplification of input IR """
+ """Module pass after basic simplification of input IR"""
return True
+
def registerOptimizerEarlyEPCallback():
- """ Module pass before the function optimization pipeline """
+ """Module pass before the function optimization pipeline"""
return True
+
def registerOptimizerLastEPCallback():
- """ Module pass after the function optimization pipeline """
+ """Module pass after the function optimization pipeline"""
return True
+
def registerPeepholeEPCallback():
- """ Function pass after each instance of the instruction combiner pass """
+ """Function pass after each instance of the instruction combiner pass"""
return True
+
def registerScalarOptimizerLateEPCallback():
- """ Function pass after most of the main optimizations, but before the last
- cleanup-ish optimizations"""
+ """Function pass after most of the main optimizations, but before the last
+ cleanup-ish optimizations"""
return True
+
def registerVectorizerStartEPCallback():
- """ Function pass before the vectorizer and other highly target specific
- optimization passes are executed. """
+ """Function pass before the vectorizer and other highly target specific
+ optimization passes are executed."""
return True
+
def registerVectorizerEndEPCallback():
- """ Function pass after the vectorizer and other highly target specific
- optimization passes are executed. """
+ """Function pass after the vectorizer and other highly target specific
+ optimization passes are executed."""
return True
+
def registerFullLinkTimeOptimizationEarlyEPCallback():
- """ Module pass at the start of the full LTO pipeline """
+ """Module pass at the start of the full LTO pipeline"""
return True
+
def registerFullLinkTimeOptimizationLastEPCallback():
- """ Module pass at the end of the full LTO pipeline """
+ """Module pass at the end of the full LTO pipeline"""
return True
+
def run(input, ctx, stage):
print(f"0x{input:016x} {stage}")
--- lld/test/ELF/lto/pypass-plugin-pipeline-parsing.py 2025-12-05
14:04:00.000000 +0000
+++ lld/test/ELF/lto/pypass-plugin-pipeline-parsing.py 2025-12-08
09:57:14.746691 +0000
@@ -7,10 +7,12 @@
# RUN: ld.lld --load-pass-plugin=%plugindir/pypass-plugin%pluginext \
# RUN: --lto-newpm-passes=pypass %t.o -o /dev/null | FileCheck %s
#
# CHECK: 0x{{[0-9a-f]+}} Module
+
def registerModulePipelineParsingCallback():
return True
+
def run(input, ctx, stage):
print(f"0x{input:016x} {stage}")
--- llvm/test/tools/plugins-shlib/Inputs/mymod.py 2025-12-05
14:04:00.000000 +0000
+++ llvm/test/tools/plugins-shlib/Inputs/mymod.py 2025-12-08
09:57:14.781543 +0000
@@ -1,4 +1,5 @@
import sys
+
def pyversion():
print(f"Python version: {sys.version}")
--- llvm/test/tools/plugins-shlib/pypass-functions.py 2025-12-05
14:04:00.000000 +0000
+++ llvm/test/tools/plugins-shlib/pypass-functions.py 2025-12-08
09:57:14.789674 +0000
@@ -6,15 +6,18 @@
# RUN: -passes=pypass -disable-output %S/Inputs/foobar.ll | FileCheck %s
# CHECK: 0x{{[0-9a-f]+}} Function
# CHECK: 0x{{[0-9a-f]+}} Function
+
def registerModulePipelineParsingCallback():
- """ Call run for each module that goes through the pipeline """
+ """Call run for each module that goes through the pipeline"""
return False
+
def registerFunctionPipelineParsingCallback():
- """ Call run for each function that goes through the pipeline """
+ """Call run for each function that goes through the pipeline"""
return True
+
def run(input, ctx, stage):
print(f"0x{input:016x} {stage}")
--- llvm/test/tools/plugins-shlib/pypass.py 2025-12-05 14:04:00.000000 +0000
+++ llvm/test/tools/plugins-shlib/pypass.py 2025-12-08 09:57:14.798311 +0000
@@ -20,15 +20,18 @@
# CHECK: Python version: 3
# CHECK: 0x{{[0-9a-f]+}} Module
# We can import modules relative to the script directory
from Inputs.mymod import pyversion
+
pyversion()
+
# We don't forward the actual pipeline parsing callback (yet)
def registerModulePipelineParsingCallback():
- """ Call run for each module that goes through the pipeline """
+ """Call run for each module that goes through the pipeline"""
return True
+
# We get the addresses of the C API LLVMModule and LLVMContext
def run(mod, ctx, stage):
print(f"0x{mod:016x} {stage}")
``````````
</details>
https://github.com/llvm/llvm-project/pull/171101
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits