fhahn added inline comments.
================
Comment at: lib/Basic/Targets/AArch64.cpp:94
llvm::AArch64::parseCPUArch(Name) !=
- static_cast<unsigned>(llvm::AArch64::ArchKind::AK_INVALID);
+ llvm::AArch64::ArchKind::INVALID;
}
----------------
rovka wrote:
> My eyes might be deceiving me, but did you run clang-format?
Yes, it fits on a single line now, excellent spot :)
================
Comment at: lib/Driver/ToolChains/Darwin.cpp:71
const llvm::Triple::ArchType Arch = getArchTypeForMachOArchName(Str);
- unsigned ArchKind = llvm::ARM::parseArch(Str);
+ llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Str);
T.setArch(Arch);
----------------
rovka wrote:
> Nitpick: The rename seems unnecessary (and anyway the file is inconsistent
> between Arch, ArchKind and AK).
Agreed.
https://reviews.llvm.org/D35884
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
