================
@@ -200,25 +201,26 @@ template <> void yamlize(IO &IO, ChecksVariant &Val,
bool, EmptyContext &Ctx) {
}
}
-static void mapChecks(IO &IO, std::optional<std::string> &Checks) {
+static void mapGlobList(IO &IO, std::optional<std::string> &GlobList,
+ const char *Key) {
----------------
localspook wrote:
`mapOptional` takes a `StringRef`:
https://github.com/llvm/llvm-project/blob/39fcd2cb81136a25fe7274044979957eb0619c4e/llvm/include/llvm/Support/YAMLTraits.h#L799
so I think we should as well:
```suggestion
static void mapGlobList(IO &IO, std::optional<std::string> &GlobList,
StringRef Key) {
```
https://github.com/llvm/llvm-project/pull/171816
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
