https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/171882
Add support the ChooseExpr for scalar expr >From 51c70d0b9d087cb8e9fd02cf7a657724f35253a4 Mon Sep 17 00:00:00 2001 From: Amr Hesham <[email protected]> Date: Thu, 11 Dec 2025 19:55:33 +0100 Subject: [PATCH] [CIR] Add support the ChooseExpr for scalar --- clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp | 3 +-- clang/test/CIR/CodeGen/choose-expr.cpp | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 clang/test/CIR/CodeGen/choose-expr.cpp diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp index 3887433e5e181..8e99b308de36f 100644 --- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp +++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp @@ -1354,8 +1354,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> { } mlir::Value VisitChooseExpr(ChooseExpr *e) { - cgf.cgm.errorNYI(e->getSourceRange(), "ScalarExprEmitter: choose"); - return {}; + return Visit(e->getChosenSubExpr()); } mlir::Value VisitObjCStringLiteral(const ObjCStringLiteral *e) { diff --git a/clang/test/CIR/CodeGen/choose-expr.cpp b/clang/test/CIR/CodeGen/choose-expr.cpp new file mode 100644 index 0000000000000..f1eb21adc52e3 --- /dev/null +++ b/clang/test/CIR/CodeGen/choose-expr.cpp @@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN: FileCheck --input-file=%t-cir.ll %s -check-prefix=LLVM +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -Wno-unused-value -emit-llvm %s -o %t.ll +// RUN: FileCheck --input-file=%t.ll %s -check-prefix=OGCG + +void choose_expr() { + int a = __builtin_choose_expr(1, 2, 3); +} + +// CIR: %[[A_ADDR:.*]] = cir.alloca !s32i, !cir.ptr<!s32i>, ["a", init] +// CIR: %[[CONST_2:.*]] = cir.const #cir.int<2> : !s32i +// CIR: cir.store {{.*}} %[[CONST_2]], %[[A_ADDR]] : !s32i, !cir.ptr<!s32i> + +// LLVM: %[[A_ADDR:.*]] = alloca i32, i64 1, align 4 +// LLVM: store i32 2, ptr %[[A_ADDR]], align 4 + +// OGCG: %[[A_ADDR:.*]] = alloca i32, align 4 +// OGCG: store i32 2, ptr %[[A_ADDR]], align 4 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
