fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#824079, @jyknight wrote:
> In https://reviews.llvm.org/D34158#823316, @fedor.sergeev wrote: > > > Hmm... I tried this patch and now the following worries me: > > > > - it passes -finclude-if-exists stdc-predef.h on all platforms (say, > > including my Solaris platform that has no system stdc-predef.h) > > > Right, but Solaris probably _ought_ to add one as well, to define those > macros. Point taken, started internal discussion with Solaris header folks. > +1 for using a <> include -- that does seem better. This is the only remaining issue that I would like to see fixed here. Repository: rL LLVM https://reviews.llvm.org/D34158 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits