[clang] [clang-tools-extra] [clang-tidy] `bugprone-unchecked-optional-access`: handle inheritance from `BloombergLP::bslstl::Optional_Base` to prevent false-positives for allocator-aware BDE types (PR #168863)

[Valentyn Yukhymenko via cfe-commits]

================
@@ -78,6 +78,12 @@ static bool hasOptionalClassName(const CXXRecordDecl &RD) {
                             isFullyQualifiedNamespaceEqualTo(*N, "folly"));
   }
 
+  if (RD.getName() == "Optional_Base") {
----------------
BaLiKfromUA wrote:

@jvoung I think mentioned test is exactly what I was looking for.

I tried to write similar test with `bsl::optional` mocks but found out that 
value constructors don't work currently even without my patch 😅 

So I probably will fix it in a separate PR, I believe it's related to the 
number of arguments and `enable_if` tricks in BDE.

[Compiler explorer link to 
illustrate](https://compiler-explorer.com/z/hzM8e7h17)

https://github.com/llvm/llvm-project/pull/168863
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits