================
@@ -588,16 +588,15 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
cir::CmpOp createCompare(mlir::Location loc, cir::CmpOpKind kind,
mlir::Value lhs, mlir::Value rhs) {
- return cir::CmpOp::create(*this, loc, kind, lhs, rhs);
+ return cir::CmpOp::create(*this, loc, getBoolTy(), kind, lhs, rhs);
}
cir::VecCmpOp createVecCompare(mlir::Location loc, cir::CmpOpKind kind,
mlir::Value lhs, mlir::Value rhs) {
VectorType vecCast = mlir::cast<VectorType>(lhs.getType());
IntType integralTy =
getSIntNTy(getCIRIntOrFloatBitWidth(vecCast.getElementType()));
- VectorType integralVecTy =
- VectorType::get(context, integralTy, vecCast.getSize());
+ VectorType integralVecTy = VectorType::get(integralTy, vecCast.getSize());
----------------
andykaylor wrote:
```suggestion
VectorType integralVecTy = cir::VectorType::get(integralTy,
vecCast.getSize());
```
We've been trying to make `cir` namespace uses explicit to avoid ambiguity, but
it looks like we missed this one (and the cast earlier in this function).
https://github.com/llvm/llvm-project/pull/172346
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
