Author: Nikita Popov Date: 2025-12-16T09:48:38+01:00 New Revision: 3d069684375ab5bc1f71b895db8d15eb88cfb2b1
URL: https://github.com/llvm/llvm-project/commit/3d069684375ab5bc1f71b895db8d15eb88cfb2b1 DIFF: https://github.com/llvm/llvm-project/commit/3d069684375ab5bc1f71b895db8d15eb88cfb2b1.diff LOG: [CodeGen] Use getAllOnesValue() for -1 constants Added: Modified: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCUDANV.cpp clang/lib/CodeGen/CGGPUBuiltin.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp index fa13240e74e87..d3abf6d2a1f2d 100644 --- a/clang/lib/CodeGen/CGBuiltin.cpp +++ b/clang/lib/CodeGen/CGBuiltin.cpp @@ -4263,7 +4263,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, llvm::Type *IntTy = ConvertType(E->getType()); Value *Zero = Constant::getNullValue(IntTy); Value *One = ConstantInt::get(IntTy, 1); - Value *NegativeOne = ConstantInt::get(IntTy, -1); + Value *NegativeOne = ConstantInt::getAllOnesValue(IntTy); Value *SignResult = Builder.CreateSelect(IsNeg, NegativeOne, One); Value *Result = Builder.CreateSelect(IsInf, SignResult, Zero); return RValue::get(Result); @@ -4679,7 +4679,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, PHINode *Ret = Builder.CreatePHI(IntTy, 4); Ret->addIncoming(ConstantInt::get(IntTy, 0), Entry); Ret->addIncoming(ConstantInt::get(IntTy, 1), CmpGT); - Ret->addIncoming(ConstantInt::get(IntTy, -1), CmpLT); + Ret->addIncoming(ConstantInt::getAllOnesValue(IntTy), CmpLT); Ret->addIncoming(ConstantInt::get(IntTy, 0), Next); return RValue::get(Ret); } diff --git a/clang/lib/CodeGen/CGCUDANV.cpp b/clang/lib/CodeGen/CGCUDANV.cpp index 34bf41d8b7ed1..e04da90b3cbf6 100644 --- a/clang/lib/CodeGen/CGCUDANV.cpp +++ b/clang/lib/CodeGen/CGCUDANV.cpp @@ -637,7 +637,7 @@ llvm::Function *CGNVCUDARuntime::makeRegisterGlobalsFn() { KernelHandles[I.Kernel->getName()], KernelName, KernelName, - llvm::ConstantInt::get(IntTy, -1), + llvm::ConstantInt::getAllOnesValue(IntTy), NullPtr, NullPtr, NullPtr, diff --git a/clang/lib/CodeGen/CGGPUBuiltin.cpp b/clang/lib/CodeGen/CGGPUBuiltin.cpp index c133b5f3c0293..47cac03b64532 100644 --- a/clang/lib/CodeGen/CGGPUBuiltin.cpp +++ b/clang/lib/CodeGen/CGGPUBuiltin.cpp @@ -174,7 +174,7 @@ RValue CodeGenFunction::EmitAMDGPUDevicePrintfCallExpr(const CallExpr *E) { // We don't know how to emit non-scalar varargs. if (!A.getRValue(*this).isScalar()) { CGM.ErrorUnsupported(E, "non-scalar arg to printf"); - return RValue::get(llvm::ConstantInt::get(IntTy, -1)); + return RValue::get(llvm::ConstantInt::getAllOnesValue(IntTy)); } llvm::Value *Arg = A.getRValue(*this).getScalarVal(); diff --git a/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp b/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp index f72d9384313f1..db0d56d6b18cc 100644 --- a/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp +++ b/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp @@ -1287,7 +1287,7 @@ void CGOpenMPRuntimeGPU::emitParallelCall( IfCondVal = llvm::ConstantInt::get(CGF.Int32Ty, 1); if (!NumThreadsVal) - NumThreadsVal = llvm::ConstantInt::get(CGF.Int32Ty, -1); + NumThreadsVal = llvm::ConstantInt::getAllOnesValue(CGF.Int32Ty); else NumThreadsVal = Bld.CreateZExtOrTrunc(NumThreadsVal, CGF.Int32Ty); @@ -1301,7 +1301,7 @@ void CGOpenMPRuntimeGPU::emitParallelCall( getThreadID(CGF, Loc), IfCondVal, NumThreadsVal, - llvm::ConstantInt::get(CGF.Int32Ty, -1), + llvm::ConstantInt::getAllOnesValue(CGF.Int32Ty), FnPtr, ID, Bld.CreateBitOrPointerCast(CapturedVarsAddrs.emitRawPointer(CGF), _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
