================ @@ -0,0 +1,10 @@ +// RUN: not %clang_cc1 -triple x86_64-unknown-unknown -fsycl-is-device %s 2>&1 | FileCheck --check-prefixes=INVALID %s ---------------- Fznamznon wrote:
Ah, no I was probably too eager giving my LGTM on this. I'm curious why this is checked by a FileCheck and not by -verify? And why no target passed at all is considered valid? Also, can we please add a test that actually has an attribute `[[clang::sycl_kernel_entry_point]]` on a function and actually tries to emit IR with an invalid target? I.e. can we add a test with the original reproducer from https://github.com/llvm/llvm-project/issues/167358 to verify there is no crash anymore? https://github.com/llvm/llvm-project/pull/172366 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
