weliveindetail wrote:

Feedback so far is, that these tests aren't necessary. I think they are.

There is value in documenting plugin entry-points for tools in their individual 
configurations. It makes sense to do this in tests in a readable way. We must 
fix them if the behavior changes and we can add entry-points when we introduce 
new ones. It would be easy to check which version of which tools supported 
which set of entry-points.

Yes, there are tests for the individual pipelines in LLVM. These are tests for 
core features, they are hard to read and they give no overview. I can imagine 
that this is all obvious for full-time LLVM experts, but it's not clear for 
plugin developers who use LLVM as one tool out of many. I think we should 
provide better transparency and this patch could help.

Let me leave the PR here for documentation for now. And maybe as a reference 
for people who start working with pass plugins in the future.

https://github.com/llvm/llvm-project/pull/172463
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to