llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-modules Author: Michael Park (mpark) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/172524.diff 2 Files Affected: - (modified) clang/lib/Serialization/ASTWriter.cpp (+1-1) - (modified) clang/test/CXX/module/module.reach/p5.cpp (+1-1) ``````````diff diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp index 899fd69c2045e..0638f2c4efbe8 100644 --- a/clang/lib/Serialization/ASTWriter.cpp +++ b/clang/lib/Serialization/ASTWriter.cpp @@ -4641,7 +4641,7 @@ uint64_t ASTWriter::WriteSpecializationInfoLookupTable( return Offset; } -/// Returns ture if all of the lookup result are either external, not emitted or +/// Returns true if all of the lookup result are either external, not emitted or /// predefined. In such cases, the lookup result is not interesting and we don't /// need to record the result in the current being written module. Return false /// otherwise. diff --git a/clang/test/CXX/module/module.reach/p5.cpp b/clang/test/CXX/module/module.reach/p5.cpp index 947fd082553ec..f977049f2e996 100644 --- a/clang/test/CXX/module/module.reach/p5.cpp +++ b/clang/test/CXX/module/module.reach/p5.cpp @@ -13,5 +13,5 @@ export using Y = X; //--- B.cppm export module B; import A; -Y y; // OK, definition of X is reachable +Y y; // OK, definition of Y is reachable X x; // expected-error {{unknown type name 'X'}} `````````` </details> https://github.com/llvm/llvm-project/pull/172524 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
