https://github.com/localspook approved this pull request.
I have a question about a pathological case where the same parameter is spelled
differently in different redeclarations. For example:
```cpp
using int_ptr = int *;
using f_signature = void(int *);
// All the same function.
void f(int_ptr);
f_signature f;
void f(int * p) {}
```
In this case, we can't change the type of parameter `p` to, say, `int const *`,
because there's no way to reflect that change in the other redeclarations. How
does the check currently react to this? I can't imagine this is common though,
so if the check mishandles that, I would be okay with accepting that.
Besides that, just a few cosmetic comments, and LGTM!
https://github.com/llvm/llvm-project/pull/171215
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
