llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) <details> <summary>Changes</summary> Static analysis flagged this as not applying rule of three properly. The code was trying to do the right thing but basically they are effectively all defaulted, so we make it explicit. --- Full diff: https://github.com/llvm/llvm-project/pull/172782.diff 1 Files Affected: - (modified) clang/include/clang/AST/TypeBase.h (+2-3) ``````````diff diff --git a/clang/include/clang/AST/TypeBase.h b/clang/include/clang/AST/TypeBase.h index f546393f6d8c3..b0fdf178ab3cc 100644 --- a/clang/include/clang/AST/TypeBase.h +++ b/clang/include/clang/AST/TypeBase.h @@ -6797,9 +6797,8 @@ class SpirvOperand { SpirvOperand(SpirvOperandKind Kind, QualType ResultType, llvm::APInt Value) : Kind(Kind), ResultType(ResultType), Value(std::move(Value)) {} - SpirvOperand(const SpirvOperand &Other) { *this = Other; } - ~SpirvOperand() {} - + SpirvOperand(const SpirvOperand &Other) = default; + ~SpirvOperand() = default; SpirvOperand &operator=(const SpirvOperand &Other) = default; bool operator==(const SpirvOperand &Other) const { `````````` </details> https://github.com/llvm/llvm-project/pull/172782 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
