https://github.com/ilinpv commented:
LGTM overall. As a possible follow-up (or to strengthen this change), it might be worth adding tests covering a few additional corner cases and make behaviour implicit: two versions with identical feature sets but different priorities, can we make default unreachable, using simultaneously target_clones and target_version with priorities override, changing the order of overriding priorities. https://github.com/llvm/llvm-project/pull/171496 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
