https://github.com/hekota commented:

The codegen load & store tests seem a bit overblown. I don't think it is 
necessary to test every single combination of the indices; 2-3 variants would 
suffice. I don't think testing all of the possible combinations adds value and 
it makes harder to review.

Also, please add a test that will execute the MatrixElementExpr instantiation 
(`TreeTransform<Derived>::TransformMatrixElementExpr` ).

https://github.com/llvm/llvm-project/pull/171225
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to