================ @@ -417,6 +417,95 @@ static mlir::Value emitX86vpcom(CIRGenBuilderTy &builder, mlir::Location loc, return builder.createVecCompare(loc, pred, op0, op1); } +// Emits masked result similar to EmitX86MaskedCompareResult in +// clang/lib/CodeGen/TargetBuiltins/X86.cpp +static mlir::Value emitX86MaskedResult(CIRGenBuilderTy &builder, ---------------- andykaylor wrote:
```suggestion static mlir::Value emitX86MaskedCompareResult(CIRGenBuilderTy &builder, ``` Was there a reason you didn't want to keep "Compare" in the name? Keeping the names that are used in classic codegen (after changing them to camelCase) makes them easier to find when porting other code that uses them and avoids introducing duplicates. FYI, this function was upstreamed yesterday : https://github.com/llvm/llvm-project/pull/171694 You can add the `if (maskIn)` handling if your tests exercise that. https://github.com/llvm/llvm-project/pull/172813 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
