teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
E.g. If you add a flag that lands in between the results it breaks. Add `-Wmajor-new-feature` and the test goes red. Same with the flag results or changing the help test for `-std=`. We could fix that by making the test less aggressive but it's already too forgiving right now (It actually passes when you completely break the autocomplete filtering feature and just return everything). Maybe we need a smart solution(TM) in the future where we solve this in a more stable way while still actually testing the shipped clang binaries autocomplete feature. ================ Comment at: clang/test/Driver/autocomplete.c:2 +// Test for --autocompletion flag, which is a API used for shell autocompletion. +// If this test had broke due to adding/modifying flags or changing HelpText, +// please modify this file according to the change you have made on flags used in this file. ---------------- "test had broke" -> "test broke" https://reviews.llvm.org/D36209 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
