tbaederr wrote:

> I don't like testing just the specific reported symptom, as that makes it 
> easy to unnecessarily miss or regress trivially similar issues.

Well you're testing tons of things which are already tested in other places. 
The test should me as minimal as possible, then we can also easily add it to an 
existing test in `test/AST/ByteCode/`, where other bytecode-specific tests are. 
The tests for _this specific issue_ can be tiny, testing for all the format 
literal stuff can go into `Sema/` and be independent of the bytecode 
interpreter.


https://github.com/llvm/llvm-project/pull/173212
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to