timon-ul wrote: > Can we add a background index test that fails without the ShouldTraverseDecl > change? (As a general principle, any issue we discover through "manual" > testing that wasn't caught by our automated tests, we should ideally add an > automated test for where practical.)
I gladly would add a test if I understood how to trigger this behaviour. To be fair i have yet to try writing a test for this but I mentioned earlier that my 2 cpp 1 hpp test project somehow never ran into this issue and it is a bit unclear to me why. Will try for a test tho. >Unlike the case of templated call sites, this one should be fairly easy to >make work, so maybe we should do that as part of this patch. Alright, then let's add it. Will see if I can figure this out today. https://github.com/llvm/llvm-project/pull/169742 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
