zeyi2 wrote:

> Please help me with the errors and suggest some changes :).

Sure!

- RST:
```
clang-tools-extra/docs/clang-tidy/checks/misc/anonymous-namespace-in-header.rst:8:
 D001 Line too long
clang-tools-extra/docs/clang-tidy/checks/misc/anonymous-namespace-in-header.rst:19:
 D005 No newline at end of file
clang-tools-extra/docs/clang-tidy/checks/google/build-namespaces.rst:8: D005 No 
newline at end of file
```

As the error suggests, line 8 of `anonymous-namespace-in-header.rst` exceeds 80 
char limits (I think this line is exactly 80 chars long?), so is line 9 and 
line 10 (though these errors are not fired, IMO this might be a config issue. 
I'll fix it tomorrow).   

Also, please add a new line at the end of `anonymous-namespace-in-header.rst` 
and `build-namespaces.rst`.

- Clang-tidy:
```
clang-tools-extra/clang-tidy/fuchsia/FuchsiaTidyModule.cpp:11:1: warning: 
included header ClangTidyModuleRegistry.h is not used directly 
[misc-include-cleaner]
   11 | #include "../ClangTidyModuleRegistry.h"
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   12 | #include "../misc/AnonymousNamespaceInHeaderCheck.h"



clang-tools-extra/clang-tidy/misc/AnonymousNamespaceInHeaderCheck.h:13:1: 
warning: included header FileExtensionsUtils.h is not used directly 
[misc-include-cleaner]
   13 | #include "../utils/FileExtensionsUtils.h"
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   14 | 

clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:11:1: warning: included 
header ClangTidyModuleRegistry.h is not used directly [misc-include-cleaner]
   11 | #include "../ClangTidyModuleRegistry.h"
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   12 | #include "AnonymousNamespaceInHeaderCheck.h"
```

No longer need to include these headers. This will also fix Linux build error.

- Windows build

In clang-tidy we want to maintain alphabetical order in the documentation, 
please follow the diff given in the build log to move the entry around :)


https://github.com/llvm/llvm-project/pull/173484
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to