================
@@ -18,9 +18,8 @@ namespace clang::tidy::android {
ComparisonInTempFailureRetryCheck::ComparisonInTempFailureRetryCheck(
StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context),
- RawRetryList(Options.get("RetryMacros", "TEMP_FAILURE_RETRY")) {
- RawRetryList.split(RetryMacros, ",", -1, false);
-}
+ RawRetryList(Options.get("RetryMacros", "TEMP_FAILURE_RETRY")),
+ RetryMacros(llvm::split(RawRetryList, ',')) {}
----------------
localspook wrote:
Ah, you're right, I didn't consider that. I went and looked at all the places
these options are used, and I didn't notice any cases where an empty string
could affect behaviour, but "I didn't notice" isn't solid proof. If anyone
feels uncomfortable with this change, I could look into filtering out the empty
strings.
https://github.com/llvm/llvm-project/pull/174129
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
