https://github.com/Sirraide commented:
I’m no SARIF expert, but as someone who has looked into nested diagnostics before, I feel like if we want to have nesting support (other than the very basic ‘notes nested within warnings/errors’), then we should probably start w/ adding support for that to the code that actually emits diagnostics (i.e. `DiagnosticsEngine` etc.) On the other hand if all this aims to do is to properly nest notes in errors/warnings (because I know that we’re not doing that at the moment even though SARIF supports it—or at least we weren’t a few months ago), then this candidly seems like a lot of new code and refactoring just for tbat, but admittedly I also haven’t looked into this too much wrt SARIF specifically. https://github.com/llvm/llvm-project/pull/174106 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
