klimek added inline comments.
================ Comment at: clangd/ClangdUnitStore.cpp:45 + .first; + Result.RemovedFile = nullptr; + } else if (!compileCommandsAreEqual(It->second->getCompileCommand(), ---------------- Just say RemovedFile = nullptr in the struct? ================ Comment at: clangd/ClangdUnitStore.h:45-48 + struct RecreateResult { + std::shared_ptr<CppFile> FileInCollection; + std::shared_ptr<CppFile> RemovedFile; + }; ---------------- Not obvious to me what things in there mean. https://reviews.llvm.org/D36398 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits