vabridgers wrote: > > What about put this check in "readability" module instead of "misc"? > > I think `misc` is appropriate as it changes the lifetime of variables. If > this is ever extended to non-POD types without side effects it could also > have impact on the generated code and `readability` should not affect that > IMO.
I agree, was going to write I had a problem with "readability" since reducing scope is more than just improving "readability". Thanks for the excellent comments, I'll continue to improve the PR. I'd like to minimize scope increase. Are the existing set of LIT tests enough that if supported we can agree this initial PR is "feature complete"? Best! https://github.com/llvm/llvm-project/pull/175429 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
