llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) <details> <summary>Changes</summary> Summary: CUDA's Toolchain doesn't support debug information with optimizations, so we warn on this. The logic was printing this even if you pass `-O0` yourself. Also fix not passing `-g`. --- Full diff: https://github.com/llvm/llvm-project/pull/175628.diff 1 Files Affected: - (modified) clang/tools/clang-nvlink-wrapper/ClangNVLinkWrapper.cpp (+4-2) ``````````diff diff --git a/clang/tools/clang-nvlink-wrapper/ClangNVLinkWrapper.cpp b/clang/tools/clang-nvlink-wrapper/ClangNVLinkWrapper.cpp index a6c7a3affa97d..d944dcc1f3dbb 100644 --- a/clang/tools/clang-nvlink-wrapper/ClangNVLinkWrapper.cpp +++ b/clang/tools/clang-nvlink-wrapper/ClangNVLinkWrapper.cpp @@ -322,13 +322,15 @@ Expected<StringRef> runPTXAs(StringRef File, const ArgList &Args) { if (Args.hasArg(OPT_verbose)) AssemblerArgs.push_back("-v"); if (Args.hasArg(OPT_g)) { - if (Args.hasArg(OPT_O)) + if (Args.getLastArgValue(OPT_O, "3")) WithColor::warning(errs(), Executable) << "Optimized debugging not supported, overriding to '-O0'\n"; AssemblerArgs.push_back("-O0"); - } else + AssemblerArgs.push_back("-g"); + } else { AssemblerArgs.push_back( Args.MakeArgString("-O" + Args.getLastArgValue(OPT_O, "3"))); + } AssemblerArgs.append({"-arch", Args.getLastArgValue(OPT_arch)}); AssemblerArgs.append({"-o", *TempFileOrErr}); `````````` </details> https://github.com/llvm/llvm-project/pull/175628 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
