llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-analysis Author: Rohan Jacob-Rao (rohanjr) <details> <summary>Changes</summary> Trivial renaming following the [style guide](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly). This is mostly to familiarize myself with the workflow for contributing to LLVM. --- Full diff: https://github.com/llvm/llvm-project/pull/176286.diff 1 Files Affected: - (modified) clang/lib/Analysis/UnsafeBufferUsage.cpp (+11-11) ``````````diff diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp index 6bb08102c0345..3e4d14c51ca1e 100644 --- a/clang/lib/Analysis/UnsafeBufferUsage.cpp +++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp @@ -128,10 +128,10 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { // descendants of a given node "n" except for the ones // belonging to a different callable of "n". MatchDescendantVisitor(ASTContext &Context, FastMatcher &Matcher, - bool FindAll, bool ignoreUnevaluatedContext, + bool FindAll, bool IgnoreUnevaluatedContext, const UnsafeBufferUsageHandler &NewHandler) : Matcher(&Matcher), FindAll(FindAll), Matches(false), - ignoreUnevaluatedContext(ignoreUnevaluatedContext), + IgnoreUnevaluatedContext(IgnoreUnevaluatedContext), ActiveASTContext(&Context), Handler(&NewHandler) { ShouldVisitTemplateInstantiations = true; ShouldVisitImplicitCode = false; // TODO: let's ignore implicit code for now @@ -169,7 +169,7 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { bool TraverseGenericSelectionExpr(GenericSelectionExpr *Node) override { // These are unevaluated, except the result expression. - if (ignoreUnevaluatedContext) + if (IgnoreUnevaluatedContext) return TraverseStmt(Node->getResultExpr()); return DynamicRecursiveASTVisitor::TraverseGenericSelectionExpr(Node); } @@ -177,7 +177,7 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { bool TraverseUnaryExprOrTypeTraitExpr(UnaryExprOrTypeTraitExpr *Node) override { // Unevaluated context. - if (ignoreUnevaluatedContext) + if (IgnoreUnevaluatedContext) return true; return DynamicRecursiveASTVisitor::TraverseUnaryExprOrTypeTraitExpr(Node); } @@ -185,7 +185,7 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { bool TraverseTypeOfExprTypeLoc(TypeOfExprTypeLoc Node, bool TraverseQualifier) override { // Unevaluated context. - if (ignoreUnevaluatedContext) + if (IgnoreUnevaluatedContext) return true; return DynamicRecursiveASTVisitor::TraverseTypeOfExprTypeLoc( Node, TraverseQualifier); @@ -194,7 +194,7 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { bool TraverseDecltypeTypeLoc(DecltypeTypeLoc Node, bool TraverseQualifier) override { // Unevaluated context. - if (ignoreUnevaluatedContext) + if (IgnoreUnevaluatedContext) return true; return DynamicRecursiveASTVisitor::TraverseDecltypeTypeLoc( Node, TraverseQualifier); @@ -202,14 +202,14 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { bool TraverseCXXNoexceptExpr(CXXNoexceptExpr *Node) override { // Unevaluated context. - if (ignoreUnevaluatedContext) + if (IgnoreUnevaluatedContext) return true; return DynamicRecursiveASTVisitor::TraverseCXXNoexceptExpr(Node); } bool TraverseCXXTypeidExpr(CXXTypeidExpr *Node) override { // Unevaluated context. - if (ignoreUnevaluatedContext) + if (IgnoreUnevaluatedContext) return true; return DynamicRecursiveASTVisitor::TraverseCXXTypeidExpr(Node); } @@ -247,7 +247,7 @@ class MatchDescendantVisitor : public DynamicRecursiveASTVisitor { // When true, finds all matches. When false, finds the first match and stops. const bool FindAll; bool Matches; - bool ignoreUnevaluatedContext; + bool IgnoreUnevaluatedContext; ASTContext *ActiveASTContext; const UnsafeBufferUsageHandler *Handler; }; @@ -266,7 +266,7 @@ forEachDescendantEvaluatedStmt(const Stmt *S, ASTContext &Ctx, const UnsafeBufferUsageHandler &Handler, FastMatcher &Matcher) { MatchDescendantVisitor Visitor(Ctx, Matcher, /*FindAll=*/true, - /*ignoreUnevaluatedContext=*/true, Handler); + /*IgnoreUnevaluatedContext=*/true, Handler); Visitor.findMatch(DynTypedNode::create(*S)); } @@ -274,7 +274,7 @@ static void forEachDescendantStmt(const Stmt *S, ASTContext &Ctx, const UnsafeBufferUsageHandler &Handler, FastMatcher &Matcher) { MatchDescendantVisitor Visitor(Ctx, Matcher, /*FindAll=*/true, - /*ignoreUnevaluatedContext=*/false, Handler); + /*IgnoreUnevaluatedContext=*/false, Handler); Visitor.findMatch(DynTypedNode::create(*S)); } `````````` </details> https://github.com/llvm/llvm-project/pull/176286 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
