https://github.com/nico updated https://github.com/llvm/llvm-project/pull/176285
>From 9a47f759b67af869e45687853f5c3a464d0562ef Mon Sep 17 00:00:00 2001 From: Nico Weber <[email protected]> Date: Thu, 15 Jan 2026 19:44:14 -0500 Subject: [PATCH 1/2] [clang] Expose -f(no-)modules-disable-diagnostic-validation as clang-cl option --- clang/include/clang/Options/Options.td | 2 +- clang/test/Driver/cl-options.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/clang/include/clang/Options/Options.td b/clang/include/clang/Options/Options.td index d4dd71b9d1bea..9bf195e3dab4d 100644 --- a/clang/include/clang/Options/Options.td +++ b/clang/include/clang/Options/Options.td @@ -3449,7 +3449,7 @@ def fmodules_validate_once_per_build_session : Flag<["-"], "fmodules-validate-on "successfully validated or loaded during this build session">, MarshallingInfoFlag<HeaderSearchOpts<"ModulesValidateOncePerBuildSession">>; def fmodules_disable_diagnostic_validation : Flag<["-"], "fmodules-disable-diagnostic-validation">, - Group<i_Group>, Visibility<[ClangOption, CC1Option]>, + Group<i_Group>, Visibility<[ClangOption, CLOption, CC1Option]>, HelpText<"Disable validation of the diagnostic options when loading the module">, MarshallingInfoNegativeFlag<HeaderSearchOpts<"ModulesValidateDiagnosticOptions">>; defm modules_force_validate_user_headers : BoolOption<"f", "modules-force-validate-user-headers", diff --git a/clang/test/Driver/cl-options.c b/clang/test/Driver/cl-options.c index 1b1169b71554a..8f2f7e4c18020 100644 --- a/clang/test/Driver/cl-options.c +++ b/clang/test/Driver/cl-options.c @@ -746,6 +746,8 @@ // RUN: -fsystem-module \ // RUN: -fmodule-map-file=foo \ // RUN: -fmodule-file=foo \ +// RUN: -fmodules-disable-diagnostic-validation \ +// RUN: -fno-modules-disable-diagnostic-validation \ // RUN: -fmodules-ignore-macro=foo \ // RUN: -fmodules-strict-decluse \ // RUN: -fmodules-decluse \ >From 5afdf5e90d691d22e328ab0fa599dab3a09cfb7e Mon Sep 17 00:00:00 2001 From: Nico Weber <[email protected]> Date: Thu, 15 Jan 2026 21:50:06 -0500 Subject: [PATCH 2/2] there is no no- variant? --- clang/test/Driver/cl-options.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clang/test/Driver/cl-options.c b/clang/test/Driver/cl-options.c index 8f2f7e4c18020..611d0d2927c43 100644 --- a/clang/test/Driver/cl-options.c +++ b/clang/test/Driver/cl-options.c @@ -747,7 +747,6 @@ // RUN: -fmodule-map-file=foo \ // RUN: -fmodule-file=foo \ // RUN: -fmodules-disable-diagnostic-validation \ -// RUN: -fno-modules-disable-diagnostic-validation \ // RUN: -fmodules-ignore-macro=foo \ // RUN: -fmodules-strict-decluse \ // RUN: -fmodules-decluse \ _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
