https://github.com/Endilll commented:
I left some comments, but we're getting there. > AvailabilityKindCompat cannot derive from AvailabilityKind, apparently > non-empty enums cannot be subclassed, so I created a straight copy. Unfortunate, but fine. Hopefully we'll get rid of this soon (read on). > I thought it wouldn't be a good fit here since function isn't deprecated yet It will become deprecated the moment this PR is merged, because we provide the migration path right away, so I don't see why we'd want `PendingDeprecationWarning`. You should add a release note along the lines of the warning, and describe the migration path for `cindex.availabilityKinds` users, which is to use `AvailabilityKind`. It'd be very nice if we can get this PR done before 22.1.0-rc2, which is scheduled for 27th. Then I'd be quite comfortable backporting this to 22 branch and start the deprecation period right away. After backporting is done, you can submit a new PR that removes all the deprecated stuff. This new PR of course won't be backported, and will wait until 23, but we will be able to reclaim any headspace occupied by this ordeal right away. https://github.com/llvm/llvm-project/pull/160296 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
