================
@@ -120,10 +120,10 @@ typedef int (*unw_find_dynamic_unwind_sections)(
extern int __unw_add_find_dynamic_unwind_sections(
unw_find_dynamic_unwind_sections find_dynamic_unwind_sections);
-// Deregister a dynacim unwind-info lookup callback.
+// Deregister a dynamic unwind-info lookup callback.
//
// Returns UNW_ESUCCESS for successful deregistrations. If the given callback
-// has already been registered then UNW_EINVAL will be returned.
+// does not present then UNW_EINVAL will be returned.
----------------
willmafh wrote:
> Most of these fixes are okay, but this change does not make sense.
@MacDue Here the function `__unw_remove_find_dynamic_unwind_sections` is using
to deregister callback, not register callback, and if you look inside its
implementation and its comments, then you will see that the comments here above
the declaration is wrong. According to the attaching image below, here we need
to check whether the given callback is present or not, and if it `does not
present`, then UNW_EINVAL will be returned.
<img width="2343" height="1662" alt="屏幕截图 2026-01-19 182814"
src="https://github.com/user-attachments/assets/3f9ab561-4f28-4e01-a321-610043218adc";
/>
https://github.com/llvm/llvm-project/pull/174565
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
