================
@@ -1235,6 +1235,11 @@ class CFG {
     bool AddEHEdges = false;
     bool AddInitializers = false;
     bool AddImplicitDtors = false;
+    // Add dtors for function parameters. In principle, function parameters are
+    // constructed and destructed in the caller context but analyses could 
still
+    // choose to include these in the callee's CFG to represent the dtors run 
on
+    // function exit.
+    bool AddParameterDtors = false;
----------------
usx95 wrote:

We do not need dtors, lifetime end markers are sufficient. The CFG change is 
needed to add lifetime end markers and/or dtors for params in paths **where the 
function does not explicitly return.** **This** **was** **an** **oversight** 
**in** **our** **last** **attempt** **where** **this** **didn't** **add param 
lifetimes for** **function** **exits** **without** a `return` **statement.**

https://github.com/llvm/llvm-project/pull/177363
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to