================
@@ -86,6 +86,10 @@ using FileIDAndOffset = std::pair<FileID, unsigned>;
 /// In addition, one bit of SourceLocation is used for quick access to the
 /// information whether the location is in a file or a macro expansion.
 ///
+/// SourceLocation operates on a character level, i.e. offsets describe
+/// character distances, but in most cases, they are used on a token level,
----------------
AaronBallman wrote:

Is "character distance" actually correct or are these byte offsets? Generally 
speaking, the source handled by the manager has been converted into UTF-8, so 
for ASCII-only data the byte and character offsets are the same, so this is 
more a question about non-ASCII input.

https://github.com/llvm/llvm-project/pull/177400
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to