[clang] [LifetimeSafety] Revisit tracking moved objects (PR #178670)

[via cfe-commits]

================
@@ -170,6 +170,8 @@ class DataflowAnalysis {
       return D->transfer(In, *F->getAs<ExpireFact>());
     case Fact::Kind::OriginFlow:
       return D->transfer(In, *F->getAs<OriginFlowFact>());
+    case Fact::Kind::MovedOrigins:
+      return D->transfer(In, *F->getAs<MovedOriginFact>());
----------------
graphite-app[bot] wrote:

Enum value mismatch: Using `Fact::Kind::MovedOrigins` (plural) but the enum is 
defined as `Fact::Kind::MovedOrigin` (singular) in Facts.h line 48. This case 
will never match, causing `MovedOriginFact` instances to never be processed by 
the transfer function.

```cpp
// Should be:
case Fact::Kind::MovedOrigin:
  return D->transfer(In, *F->getAs<MovedOriginFact>());
```
```suggestion
    case Fact::Kind::MovedOrigin:
      return D->transfer(In, *F->getAs<MovedOriginFact>());
```
  

*Spotted by [Graphite 
Agent](https://app.graphite.com/diamond/?org=llvm&ref=ai-review-comment)*<i 
class='graphite__hidden'><br /><br /><a 
href="https://app.graphite.com/github/pr/llvm/llvm-project/178670?chatWithGeneratedComment=11f6d65d-c51a-47b2-a8f2-0ac07311a2c0";><picture><source
 media="(prefers-color-scheme: dark)" 
srcset="https://static.graphite.dev/github-diamond-fix-in-graphite-dark.svg";><source
 media="(prefers-color-scheme: light)" 
srcset="https://static.graphite.dev/github-diamond-fix-in-graphite-light.svg";><img
 alt="Fix in Graphite" 
src="https://static.graphite.dev/github-diamond-fix-in-graphite-dark.svg";></picture></a></i><i
 class='graphite__hidden'><br /><br />Is this helpful? React 👍 or 👎 to let us 
know.</i>

https://github.com/llvm/llvm-project/pull/178670
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits