================
@@ -188,6 +188,11 @@ DarwinSDKInfo::parseDarwinSDKSettingsJSON(std::string
FilePath,
std::optional<StringRef> XcodePlatform = parseXcodePlatform(*Obj);
std::pair<llvm::Triple::OSType, llvm::Triple::EnvironmentType>
OSAndEnvironment = parseOSAndEnvironment(XcodePlatform);
+ // DisplayName should always be present, but don't die if it's missing for
+ // some weird reason.
----------------
cyndyishida wrote:
nit: I find this comment is a bit too casual to burn in source.
Maybe
```
// While `DisplayName` should always be present, allow fallbacks.
```
https://github.com/llvm/llvm-project/pull/176541
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
