https://github.com/HighCommander4 requested changes to this pull request.

As @vbvictor mentioned, we should add a test for this. We have [lit 
tests](https://llvm.org/docs/CommandGuide/lit.html) like 
[this](https://searchfox.org/llvm/source/clang-tools-extra/clangd/test/crash-parse.test)
 for this purpose, where you can provide clangd some LSP requests as input, and 
check that its output is what we expect (e.g. in this case, we could check for 
our log message).

https://github.com/llvm/llvm-project/pull/177834
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to