================
@@ -3296,7 +3358,7 @@ def __getitem__(self, key: int) -> CodeCompletionResult:
     def results(self) -> CCRStructure:
         warnings.warn(
             "Access to 'CodeCompletionResult's through "
-            "'CodeCompletionResults.results' will be removed in a future 
release."
+            "'CodeCompletionResults.results' will be removed in a future 
release. "
----------------
DeinAlptraum wrote:

After taking a look at 
https://docs.python.org/3/library/warnings.html#warning-categories
I don't think that `FutureWarning` is any better: it only seems to have a 
target group, but with the same meaning

Imo `DeprecationWarning` is fine since the changes we intend to make will break 
many existing uses, and the field itself is supposed to become an 
implementation detail at that point.
I don't mind changing the warning to something else either, but I don't think 
any of the others fit better here.

https://github.com/llvm/llvm-project/pull/177764
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to