================
@@ -349,6 +349,27 @@ class ModuleTranslation {
 
   SymbolTableCollection &symbolTable() { return symbolTableCollection; }
 
+  // A helper callback that takes an attribute, and if it is a StringAttr,
+  // properly converts it to the 'no-builtin-VALUE' form.
+  static std::optional<std::string> noBuiltinConverter(mlir::Attribute a) {
----------------
gysit wrote:

```suggestion
  static std::optional<std::string> convertNoBuiltin(Attribute a) {
```
nit: I believe the coding convention wants a verb first.

https://github.com/llvm/llvm-project/pull/178899
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to