================
@@ -3339,7 +3315,8 @@ void ConvertCIRToLLVMPass::runOnOperation() {
mlir::ModuleOp module = getOperation();
mlir::DataLayout dl(module);
mlir::LLVMTypeConverter converter(&getContext());
- std::unique_ptr<cir::LowerModule> lowerModule = prepareLowerModule(module);
+ std::unique_ptr<cir::LowerModule> lowerModule =
----------------
Lancern wrote:
No, `LowerModule` should no longer be needed in `LowerToLLVM`.
But I plan to make this PR as simple as possible. Removing `LowerModule` from
`LowerToLLVM` requires non-trivial amount of work (e.g. you have to update the
TableGen backend as well because `LowerModule` is included in every
`CIRToLLVMXxxOpLowering` pattern) so I decide to do it in a later PR.
https://github.com/llvm/llvm-project/pull/179245
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
