================
@@ -1288,6 +1289,13 @@ class CIRGenFunction : public CIRGenTypeCache {
                                       SourceLocation assumptionLoc,
                                       int64_t alignment,
                                       mlir::Value offsetValue = nullptr);
+  /// -----------------------------
+  /// CIR emit functions -- AArch64
+  /// -----------------------------
+  mlir::Value
+  emitAArch64CompareBuiltinExpr(mlir::Location loc, mlir::Value src,
----------------
banach-space wrote:

It's nice to be able to avoid passing `CIRGenModule` and `OpBuilder`. Also, for 
consistency, I am trying to match `CodeGenFunction`: 
https://github.com/llvm/llvm-project/blob/02804501af9c764126964a965c02dbee84690227/clang/lib/CodeGen/CodeGenFunction.h?plain=1#L4757-L4760

I should probably make both `emitAArch64CompareBuiltinExpr` and 
`EmitAArch64CompareBuiltinExpr` static functions in the implementation file.

https://github.com/llvm/llvm-project/pull/179779
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to