llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-backend-arm @llvm/pr-subscribers-clang-tools-extra Author: Steffen Larsen (steffenlarsen) <details> <summary>Changes</summary> This commit changes all `ID` fields in the LLVM codebase to be `const char` instead of `char`. These fields are never used for their values and are instead their addresses are used for RTTI and pass identification. By making them const, we avoid misuse of the fields as global state. --- Patch is 906.69 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/179970.diff 1122 Files Affected: - (modified) bolt/include/bolt/Core/BinaryContext.h (+1-1) - (modified) bolt/lib/Core/BinaryContext.cpp (+1-1) - (modified) clang-tools-extra/clangd/Protocol.cpp (+1-1) - (modified) clang-tools-extra/clangd/Protocol.h (+1-1) - (modified) clang-tools-extra/clangd/support/Cancellation.cpp (+1-1) - (modified) clang-tools-extra/clangd/support/Cancellation.h (+1-1) - (modified) clang-tools-extra/clangd/support/Logger.cpp (+2-2) - (modified) clang/include/clang/AST/ASTImportError.h (+1-1) - (modified) clang/include/clang/AST/ExternalASTSource.h (+1-1) - (modified) clang/include/clang/Basic/DiagnosticError.h (+1-1) - (modified) clang/include/clang/CrossTU/CrossTranslationUnit.h (+1-1) - (modified) clang/include/clang/ExtractAPI/APIIgnoresList.h (+1-1) - (modified) clang/include/clang/Sema/ExternalSemaSource.h (+1-1) - (modified) clang/include/clang/Sema/MultiplexExternalSemaSource.h (+1-1) - (modified) clang/include/clang/Serialization/ModuleFileExtension.h (+1-1) - (modified) clang/include/clang/Tooling/Core/Replacement.h (+1-1) - (modified) clang/lib/AST/ASTImporter.cpp (+1-1) - (modified) clang/lib/AST/ExternalASTSource.cpp (+1-1) - (modified) clang/lib/Analysis/FlowSensitive/Arena.cpp (+2-2) - (modified) clang/lib/Basic/Diagnostic.cpp (+1-1) - (modified) clang/lib/CrossTU/CrossTranslationUnit.cpp (+1-1) - (modified) clang/lib/ExtractAPI/APIIgnoresList.cpp (+1-1) - (modified) clang/lib/Frontend/TestModuleFileExtension.cpp (+1-1) - (modified) clang/lib/Frontend/TestModuleFileExtension.h (+1-1) - (modified) clang/lib/Sema/MultiplexExternalSemaSource.cpp (+1-1) - (modified) clang/lib/Sema/Sema.cpp (+1-1) - (modified) clang/lib/Serialization/ASTReader.cpp (+2-2) - (modified) clang/lib/Serialization/ModuleFileExtension.cpp (+1-1) - (modified) clang/lib/Tooling/Core/Replacement.cpp (+1-1) - (modified) clang/lib/Tooling/Transformer/Parsing.cpp (+2-2) - (modified) clang/unittests/Frontend/CompilerInvocationTest.cpp (+2-2) - (modified) compiler-rt/lib/orc/rtti.cpp (+1-1) - (modified) compiler-rt/lib/orc/rtti.h (+8-8) - (modified) lldb/include/lldb/Expression/DiagnosticManager.h (+1-1) - (modified) lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h (+1-1) - (modified) lldb/include/lldb/Expression/ExpressionVariable.h (+2-2) - (modified) lldb/include/lldb/Expression/FunctionCaller.h (+1-1) - (modified) lldb/include/lldb/Expression/LLVMUserExpression.h (+1-1) - (modified) lldb/include/lldb/Expression/ObjectFileJIT.h (+1-1) - (modified) lldb/include/lldb/Expression/REPL.h (+1-1) - (modified) lldb/include/lldb/Expression/UserExpression.h (+1-1) - (modified) lldb/include/lldb/Expression/UtilityFunction.h (+1-1) - (modified) lldb/include/lldb/Host/File.h (+3-3) - (modified) lldb/include/lldb/Host/Host.h (+1-1) - (modified) lldb/include/lldb/Host/HostInfoBase.h (+2-2) - (modified) lldb/include/lldb/Host/JSONTransport.h (+3-3) - (modified) lldb/include/lldb/Host/common/DiagnosticsRendering.h (+1-1) - (modified) lldb/include/lldb/Protocol/MCP/MCPError.h (+2-2) - (modified) lldb/include/lldb/Symbol/ObjectFile.h (+1-1) - (modified) lldb/include/lldb/Symbol/SymbolFile.h (+2-2) - (modified) lldb/include/lldb/Symbol/SymbolFileOnDemand.h (+1-1) - (modified) lldb/include/lldb/Target/BorrowedStackFrame.h (+1-1) - (modified) lldb/include/lldb/Target/LanguageRuntime.h (+1-1) - (modified) lldb/include/lldb/Target/StackFrame.h (+1-1) - (modified) lldb/include/lldb/Utility/DataBuffer.h (+3-3) - (modified) lldb/include/lldb/Utility/DataBufferHeap.h (+1-1) - (modified) lldb/include/lldb/Utility/DataBufferLLVM.h (+2-2) - (modified) lldb/include/lldb/Utility/Log.h (+5-5) - (modified) lldb/include/lldb/Utility/Status.h (+4-4) - (modified) lldb/include/lldb/Utility/UnimplementedError.h (+1-1) - (modified) lldb/source/Expression/DiagnosticManager.cpp (+1-1) - (modified) lldb/source/Expression/ExpressionTypeSystemHelper.cpp (+1-1) - (modified) lldb/source/Expression/ExpressionVariable.cpp (+2-2) - (modified) lldb/source/Expression/FunctionCaller.cpp (+1-1) - (modified) lldb/source/Expression/LLVMUserExpression.cpp (+1-1) - (modified) lldb/source/Expression/ObjectFileJIT.cpp (+1-1) - (modified) lldb/source/Expression/REPL.cpp (+1-1) - (modified) lldb/source/Expression/UserExpression.cpp (+1-1) - (modified) lldb/source/Expression/UtilityFunction.cpp (+1-1) - (modified) lldb/source/Host/common/DiagnosticsRendering.cpp (+1-1) - (modified) lldb/source/Host/common/File.cpp (+3-3) - (modified) lldb/source/Host/common/Host.cpp (+1-1) - (modified) lldb/source/Host/common/JSONTransport.cpp (+3-3) - (modified) lldb/source/Interpreter/Options.cpp (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionHelper.cpp (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionHelper.h (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionVariable.cpp (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionVariable.h (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExternalASTSourceCallbacks.cpp (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExternalASTSourceCallbacks.h (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.h (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.h (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/CxxModuleHandler.cpp (+2-2) - (modified) lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.h (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.h (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.h (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp (+1-1) - (modified) lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h (+1-1) - (modified) lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp (+1-1) - (modified) lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h (+1-1) - (modified) lldb/source/Plugins/Process/scripted/ScriptedFrame.cpp (+1-1) - (modified) lldb/source/Plugins/Process/scripted/ScriptedFrame.h (+1-1) - (modified) lldb/source/Plugins/REPL/Clang/ClangREPL.cpp (+1-1) - (modified) lldb/source/Plugins/REPL/Clang/ClangREPL.h (+1-1) - (modified) lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp (+5-5) - (modified) lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/JSON/SymbolFileJSON.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/JSON/SymbolFileJSON.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h (+1-1) - (modified) lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp (+1-1) - (modified) lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h (+1-1) - (modified) lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp (+1-1) - (modified) lldb/source/Plugins/Trace/intel-pt/DecodedThread.h (+1-1) - (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp (+2-2) - (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h (+2-2) - (modified) lldb/source/Protocol/MCP/MCPError.cpp (+2-2) - (modified) lldb/source/Symbol/ObjectFile.cpp (+1-1) - (modified) lldb/source/Symbol/SymbolFile.cpp (+2-2) - (modified) lldb/source/Symbol/SymbolFileOnDemand.cpp (+1-1) - (modified) lldb/source/Target/BorrowedStackFrame.cpp (+1-1) - (modified) lldb/source/Target/LanguageRuntime.cpp (+1-1) - (modified) lldb/source/Target/StackFrame.cpp (+1-1) - (modified) lldb/source/Utility/DataBufferHeap.cpp (+4-4) - (modified) lldb/source/Utility/DataBufferLLVM.cpp (+2-2) - (modified) lldb/source/Utility/Log.cpp (+5-5) - (modified) lldb/source/Utility/Status.cpp (+4-4) - (modified) lldb/source/Utility/UnimplementedError.cpp (+1-1) - (modified) lldb/tools/lldb-dap/DAPError.cpp (+2-2) - (modified) lldb/tools/lldb-dap/DAPError.h (+2-2) - (modified) lldb/unittests/Expression/DWARFExpressionTest.cpp (+2-2) - (modified) lldb/unittests/Symbol/LineTableTest.cpp (+2-2) - (modified) llvm/docs/HowToSetUpLLVMStyleRTTI.rst (+6-6) - (modified) llvm/docs/ProgrammersManual.rst (+1-1) - (modified) llvm/examples/Bye/Bye.cpp (+2-2) - (modified) llvm/examples/OrcV2Examples/LLJITWithThinLTOSummaries/LLJITWithThinLTOSummaries.cpp (+4-4) - (modified) llvm/include/llvm/Analysis/AliasAnalysis.h (+2-2) - (modified) llvm/include/llvm/Analysis/AssumptionCache.h (+1-1) - (modified) llvm/include/llvm/Analysis/BasicAliasAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/BlockFrequencyInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/BranchProbabilityInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/CallGraph.h (+1-1) - (modified) llvm/include/llvm/Analysis/CallGraphSCCPass.h (+2-2) - (modified) llvm/include/llvm/Analysis/CycleAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/DOTGraphTraitsPass.h (+2-2) - (modified) llvm/include/llvm/Analysis/DXILMetadataAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/DXILResource.h (+3-3) - (modified) llvm/include/llvm/Analysis/DependenceAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/DominanceFrontier.h (+1-1) - (modified) llvm/include/llvm/Analysis/GlobalsModRef.h (+1-1) - (modified) llvm/include/llvm/Analysis/IRSimilarityIdentifier.h (+1-1) - (modified) llvm/include/llvm/Analysis/IVUsers.h (+1-1) - (modified) llvm/include/llvm/Analysis/LazyBlockFrequencyInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/LazyBranchProbabilityInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/LazyValueInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/LoopInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/LoopPass.h (+3-3) - (modified) llvm/include/llvm/Analysis/MemoryDependenceAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/MemorySSA.h (+1-1) - (modified) llvm/include/llvm/Analysis/ModuleSummaryAnalysis.h (+2-2) - (modified) llvm/include/llvm/Analysis/OptimizationRemarkEmitter.h (+1-1) - (modified) llvm/include/llvm/Analysis/PhiValues.h (+1-1) - (modified) llvm/include/llvm/Analysis/PostDominators.h (+1-1) - (modified) llvm/include/llvm/Analysis/ProfileSummaryInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/RegionInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/RegionPass.h (+2-2) - (modified) llvm/include/llvm/Analysis/RuntimeLibcallInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/ScalarEvolution.h (+1-1) - (modified) llvm/include/llvm/Analysis/ScalarEvolutionAliasAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/ScopedNoAliasAA.h (+1-1) - (modified) llvm/include/llvm/Analysis/StackSafetyAnalysis.h (+2-2) - (modified) llvm/include/llvm/Analysis/StaticDataProfileInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/TargetLibraryInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/TargetTransformInfo.h (+1-1) - (modified) llvm/include/llvm/Analysis/TypeBasedAliasAnalysis.h (+1-1) - (modified) llvm/include/llvm/Analysis/UniformityAnalysis.h (+1-1) - (modified) llvm/include/llvm/CAS/CASNodeSchema.h (+1-1) - (modified) llvm/include/llvm/CAS/NamedValuesSchema.h (+1-1) - (modified) llvm/include/llvm/CGData/CodeGenData.h (+1-1) - (modified) llvm/include/llvm/CodeGen/AsmPrinter.h (+2-2) - (modified) llvm/include/llvm/CodeGen/AssignmentTrackingAnalysis.h (+1-1) - (modified) llvm/include/llvm/CodeGen/BasicBlockMatchingAndInference.h (+1-1) - (modified) llvm/include/llvm/CodeGen/BasicBlockSectionsProfileReader.h (+1-1) - (modified) llvm/include/llvm/CodeGen/CFIFixup.h (+1-1) - (modified) llvm/include/llvm/CodeGen/EdgeBundles.h (+1-1) - (modified) llvm/include/llvm/CodeGen/ExecutionDomainFix.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GCMetadata.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/CSEInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/IRTranslator.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/InstructionSelect.h (+2-2) - (modified) llvm/include/llvm/CodeGen/GlobalISel/Legalizer.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/LoadStoreOpt.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/Localizer.h (+1-1) - (modified) llvm/include/llvm/CodeGen/GlobalISel/RegBankSelect.h (+1-1) - (modified) llvm/include/llvm/CodeGen/IndirectThunks.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LazyMachineBlockFrequencyInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LibcallLoweringInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LiveDebugVariables.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LiveIntervals.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LiveRegMatrix.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LiveStacks.h (+1-1) - (modified) llvm/include/llvm/CodeGen/LiveVariables.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MIR2Vec.h (+3-3) - (modified) llvm/include/llvm/CodeGen/MIRFSDiscriminator.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MIRSampleProfile.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineBlockFrequencyInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineBlockHashInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineBranchProbabilityInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineCycleAnalysis.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineDominanceFrontier.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineDominators.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineFunctionPass.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineLoopInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineModuleInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachinePipeliner.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachinePostDominators.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineRegionInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineTraceMetrics.h (+1-1) - (modified) llvm/include/llvm/CodeGen/MachineUniformityAnalysis.h (+1-1) - (modified) llvm/include/llvm/CodeGen/Passes.h (+77-77) - (modified) llvm/include/llvm/CodeGen/ReachingDefAnalysis.h (+1-1) - (modified) llvm/include/llvm/CodeGen/RegAllocEvictionAdvisor.h (+1-1) - (modified) llvm/include/llvm/CodeGen/RegAllocPriorityAdvisor.h (+1-1) - (modified) llvm/include/llvm/CodeGen/RegisterUsageInfo.h (+1-1) - (modified) llvm/include/llvm/CodeGen/ReplaceWithVeclib.h (+1-1) - (modified) llvm/include/llvm/CodeGen/SelectionDAGISel.h (+1-1) - (modified) llvm/include/llvm/CodeGen/SlotIndexes.h (+1-1) - (modified) llvm/include/llvm/CodeGen/SpillPlacement.h (+1-1) - (modified) llvm/include/llvm/CodeGen/StackProtector.h (+1-1) - (modified) llvm/include/llvm/CodeGen/TargetPassConfig.h (+1-1) - (modified) llvm/include/llvm/CodeGen/VirtRegMap.h (+1-1) - (modified) llvm/include/llvm/DWP/DWPError.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/CodeView/CodeViewError.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/MSF/MSFError.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/PDB/DIA/DIAError.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/PDB/GenericError.h (+1-1) - (modified) llvm/include/llvm/DebugInfo/PDB/Native/RawError.h (+1-1) - (modified) llvm/include/llvm/Debuginfod/HTTPServer.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/Orc/Core.h (+10-10) - (modified) llvm/include/llvm/ExecutionEngine/Orc/Layer.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/Orc/MaterializationUnit.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/Orc/ObjectLinkingLayer.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/Orc/ObjectTransformLayer.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h (+1-1) - (modified) llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcError.h (+2-2) - (modified) llvm/include/llvm/ExecutionEngine/Orc/TaskDispatch.h (+3-3) - (modified) llvm/include/llvm/ExecutionEngine/RuntimeDyld.h (+1-1) - (modified) llvm/include/llvm/Frontend/HLSL/RootSignatureMetadata.h (+1-1) - (modified) llvm/include/llvm/IR/Dominators.h (+1-1) - (modified) llvm/include/llvm/IR/LLVMRemarkStreamer.h (+3-3) - (modified) llvm/include/llvm/IR/LegacyPassManagers.h (+1-1) - (modified) llvm/include/llvm/MCA/InstrBuilder.h (+1-1) - (modified) llvm/include/llvm/MCA/Stages/Stage.h (+1-1) - (modified) llvm/include/llvm/MCA/Support.h (+2-2) - (modified) llvm/include/llvm/Object/Error.h (+2-2) ``````````diff diff --git a/bolt/include/bolt/Core/BinaryContext.h b/bolt/include/bolt/Core/BinaryContext.h index 31c90d2c502bd..c7a194c2450b2 100644 --- a/bolt/include/bolt/Core/BinaryContext.h +++ b/bolt/include/bolt/Core/BinaryContext.h @@ -161,7 +161,7 @@ class FilterIterator { /// as the error is checked. class BOLTError : public ErrorInfo<BOLTError> { public: - static char ID; + static const char ID; BOLTError(bool IsFatal, const Twine &S = Twine()); void log(raw_ostream &OS) const override; diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp index f0541921c70a8..5ea0f50aa3658 100644 --- a/bolt/lib/Core/BinaryContext.cpp +++ b/bolt/lib/Core/BinaryContext.cpp @@ -92,7 +92,7 @@ static cl::opt<bool> namespace llvm { namespace bolt { -char BOLTError::ID = 0; +const char BOLTError::ID = 0; BOLTError::BOLTError(bool IsFatal, const Twine &S) : IsFatal(IsFatal), Msg(S.str()) {} diff --git a/clang-tools-extra/clangd/Protocol.cpp b/clang-tools-extra/clangd/Protocol.cpp index 9926f2dd63de5..6e77a2ae08c2f 100644 --- a/clang-tools-extra/clangd/Protocol.cpp +++ b/clang-tools-extra/clangd/Protocol.cpp @@ -41,7 +41,7 @@ bool mapOptOrNull(const llvm::json::Value &Params, llvm::StringLiteral Prop, } } // namespace -char LSPError::ID; +const char LSPError::ID = 0; URIForFile URIForFile::canonicalize(llvm::StringRef AbsPath, llvm::StringRef TUPath) { diff --git a/clang-tools-extra/clangd/Protocol.h b/clang-tools-extra/clangd/Protocol.h index a88c9a391f97a..ae3ebbe54e4b4 100644 --- a/clang-tools-extra/clangd/Protocol.h +++ b/clang-tools-extra/clangd/Protocol.h @@ -64,7 +64,7 @@ class LSPError : public llvm::ErrorInfo<LSPError> { public: std::string Message; ErrorCode Code; - static char ID; + static const char ID; LSPError(std::string Message, ErrorCode Code) : Message(std::move(Message)), Code(Code) {} diff --git a/clang-tools-extra/clangd/support/Cancellation.cpp b/clang-tools-extra/clangd/support/Cancellation.cpp index d544c17e279c7..a27feda45853d 100644 --- a/clang-tools-extra/clangd/support/Cancellation.cpp +++ b/clang-tools-extra/clangd/support/Cancellation.cpp @@ -12,7 +12,7 @@ namespace clang { namespace clangd { -char CancelledError::ID = 0; +const char CancelledError::ID = 0; // We don't want a cancelable scope to "shadow" an enclosing one. struct CancelState { diff --git a/clang-tools-extra/clangd/support/Cancellation.h b/clang-tools-extra/clangd/support/Cancellation.h index f33b0b5c67635..8d50952ca49ec 100644 --- a/clang-tools-extra/clangd/support/Cancellation.h +++ b/clang-tools-extra/clangd/support/Cancellation.h @@ -85,7 +85,7 @@ int isCancelled(const Context &Ctx = Context::current()); /// Conventional error when no result is returned due to cancellation. class CancelledError : public llvm::ErrorInfo<CancelledError> { public: - static char ID; + static const char ID; const int Reason; CancelledError(int Reason) : Reason(Reason) {} diff --git a/clang-tools-extra/clangd/support/Logger.cpp b/clang-tools-extra/clangd/support/Logger.cpp index e4e0499f9f57d..be6d27f1b1c05 100644 --- a/clang-tools-extra/clangd/support/Logger.cpp +++ b/clang-tools-extra/clangd/support/Logger.cpp @@ -71,9 +71,9 @@ class SimpleStringError : public llvm::ErrorInfo<SimpleStringError> { void log(llvm::raw_ostream &OS) const override { OS << Message; } std::string message() const override { return Message; } std::error_code convertToErrorCode() const override { return EC; } - static char ID; + static const char ID; }; -char SimpleStringError::ID; +const char SimpleStringError::ID = 0; } // namespace diff --git a/clang/include/clang/AST/ASTImportError.h b/clang/include/clang/AST/ASTImportError.h index 728314ca0936e..4669dda2273b1 100644 --- a/clang/include/clang/AST/ASTImportError.h +++ b/clang/include/clang/AST/ASTImportError.h @@ -29,7 +29,7 @@ class ASTImportError : public llvm::ErrorInfo<ASTImportError> { ErrorKind Error; - static char ID; + static const char ID; ASTImportError() : Error(Unknown) {} ASTImportError(const ASTImportError &Other) : Error(Other.Error) {} diff --git a/clang/include/clang/AST/ExternalASTSource.h b/clang/include/clang/AST/ExternalASTSource.h index 8fc490b1d8471..b55aca9a39ee7 100644 --- a/clang/include/clang/AST/ExternalASTSource.h +++ b/clang/include/clang/AST/ExternalASTSource.h @@ -68,7 +68,7 @@ class ExternalASTSource : public RefCountedBase<ExternalASTSource> { uint32_t CurrentGeneration = 0; /// LLVM-style RTTI. - static char ID; + static const char ID; public: ExternalASTSource() = default; diff --git a/clang/include/clang/Basic/DiagnosticError.h b/clang/include/clang/Basic/DiagnosticError.h index 744f7fe19db79..eb6ab8fc777e7 100644 --- a/clang/include/clang/Basic/DiagnosticError.h +++ b/clang/include/clang/Basic/DiagnosticError.h @@ -45,7 +45,7 @@ class DiagnosticError : public llvm::ErrorInfo<DiagnosticError> { return Result; } - static char ID; + static const char ID; private: // Users are not expected to use error_code. diff --git a/clang/include/clang/CrossTU/CrossTranslationUnit.h b/clang/include/clang/CrossTU/CrossTranslationUnit.h index 9e0721edfc323..ac3fda9bbc95e 100644 --- a/clang/include/clang/CrossTU/CrossTranslationUnit.h +++ b/clang/include/clang/CrossTU/CrossTranslationUnit.h @@ -60,7 +60,7 @@ enum class index_error_code { class IndexError : public llvm::ErrorInfo<IndexError> { public: - static char ID; + static const char ID; IndexError(index_error_code C) : Code(C), LineNo(0) {} IndexError(index_error_code C, std::string FileName, int LineNo = 0) : Code(C), FileName(std::move(FileName)), LineNo(LineNo) {} diff --git a/clang/include/clang/ExtractAPI/APIIgnoresList.h b/clang/include/clang/ExtractAPI/APIIgnoresList.h index 3eee8e336cb63..3e0d5287c8761 100644 --- a/clang/include/clang/ExtractAPI/APIIgnoresList.h +++ b/clang/include/clang/ExtractAPI/APIIgnoresList.h @@ -32,7 +32,7 @@ namespace extractapi { struct IgnoresFileNotFound : public llvm::ErrorInfo<IgnoresFileNotFound> { std::string Path; - static char ID; + static const char ID; explicit IgnoresFileNotFound(StringRef Path) : Path(Path) {} diff --git a/clang/include/clang/Sema/ExternalSemaSource.h b/clang/include/clang/Sema/ExternalSemaSource.h index 11cd69df88d1c..e5669a324bb05 100644 --- a/clang/include/clang/Sema/ExternalSemaSource.h +++ b/clang/include/clang/Sema/ExternalSemaSource.h @@ -49,7 +49,7 @@ struct ExternalVTableUse { /// analysis. class ExternalSemaSource : public ExternalASTSource { /// LLVM-style RTTI. - static char ID; + static const char ID; public: ExternalSemaSource() = default; diff --git a/clang/include/clang/Sema/MultiplexExternalSemaSource.h b/clang/include/clang/Sema/MultiplexExternalSemaSource.h index 8bcaa121b3039..46865d592628b 100644 --- a/clang/include/clang/Sema/MultiplexExternalSemaSource.h +++ b/clang/include/clang/Sema/MultiplexExternalSemaSource.h @@ -37,7 +37,7 @@ namespace clang { /// analysis. class MultiplexExternalSemaSource : public ExternalSemaSource { /// LLVM-style RTTI. - static char ID; + static const char ID; private: SmallVector<llvm::IntrusiveRefCntPtr<ExternalSemaSource>, 2> Sources; diff --git a/clang/include/clang/Serialization/ModuleFileExtension.h b/clang/include/clang/Serialization/ModuleFileExtension.h index 50ce401516275..a106cb66aad71 100644 --- a/clang/include/clang/Serialization/ModuleFileExtension.h +++ b/clang/include/clang/Serialization/ModuleFileExtension.h @@ -66,7 +66,7 @@ class ModuleFileExtension : public llvm::RTTIExtends<ModuleFileExtension, llvm::RTTIRoot> { public: /// Discriminator for LLVM RTTI. - static char ID; + static const char ID; virtual ~ModuleFileExtension(); diff --git a/clang/include/clang/Tooling/Core/Replacement.h b/clang/include/clang/Tooling/Core/Replacement.h index f9452111e147f..84c438f73338f 100644 --- a/clang/include/clang/Tooling/Core/Replacement.h +++ b/clang/include/clang/Tooling/Core/Replacement.h @@ -171,7 +171,7 @@ class ReplacementError : public llvm::ErrorInfo<ReplacementError> { replacement_error get() const { return Err; } - static char ID; + static const char ID; const std::optional<Replacement> &getNewReplacement() const { return NewReplacement; diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp index 101ab2c40973b..20c7a3d77d390 100644 --- a/clang/lib/AST/ASTImporter.cpp +++ b/clang/lib/AST/ASTImporter.cpp @@ -102,7 +102,7 @@ namespace clang { llvm_unreachable("Function not implemented."); } - char ASTImportError::ID; + const char ASTImportError::ID = 0; template <class T> static SmallVector<Decl *, 2> diff --git a/clang/lib/AST/ExternalASTSource.cpp b/clang/lib/AST/ExternalASTSource.cpp index e8c1004089713..bf4ca1b67c0e8 100644 --- a/clang/lib/AST/ExternalASTSource.cpp +++ b/clang/lib/AST/ExternalASTSource.cpp @@ -24,7 +24,7 @@ using namespace clang; -char ExternalASTSource::ID; +const char ExternalASTSource::ID = 0; ExternalASTSource::~ExternalASTSource() = default; diff --git a/clang/lib/Analysis/FlowSensitive/Arena.cpp b/clang/lib/Analysis/FlowSensitive/Arena.cpp index 7542a137c735e..7780ff8b143a7 100644 --- a/clang/lib/Analysis/FlowSensitive/Arena.cpp +++ b/clang/lib/Analysis/FlowSensitive/Arena.cpp @@ -180,7 +180,7 @@ class FormulaParseError : public llvm::ErrorInfo<FormulaParseError> { unsigned Offset; public: - static char ID; + static const char ID; FormulaParseError(llvm::StringRef Formula, unsigned Offset) : Formula(Formula), Offset(Offset) {} @@ -195,7 +195,7 @@ class FormulaParseError : public llvm::ErrorInfo<FormulaParseError> { } }; -char FormulaParseError::ID = 0; +const char FormulaParseError::ID = 0; } // namespace diff --git a/clang/lib/Basic/Diagnostic.cpp b/clang/lib/Basic/Diagnostic.cpp index 4802478c379bb..ef2d2b1e45734 100644 --- a/clang/lib/Basic/Diagnostic.cpp +++ b/clang/lib/Basic/Diagnostic.cpp @@ -1468,4 +1468,4 @@ DiagStorageAllocator::~DiagStorageAllocator() { "A partial is on the lam"); } -char DiagnosticError::ID; +const char DiagnosticError::ID = 0; diff --git a/clang/lib/CrossTU/CrossTranslationUnit.cpp b/clang/lib/CrossTU/CrossTranslationUnit.cpp index b0563b39e99ed..42ae9cb9fa06c 100644 --- a/clang/lib/CrossTU/CrossTranslationUnit.cpp +++ b/clang/lib/CrossTU/CrossTranslationUnit.cpp @@ -142,7 +142,7 @@ class IndexErrorCategory : public std::error_category { static llvm::ManagedStatic<IndexErrorCategory> Category; } // end anonymous namespace -char IndexError::ID; +const char IndexError::ID = 0; void IndexError::log(raw_ostream &OS) const { OS << Category->message(static_cast<int>(Code)) << '\n'; diff --git a/clang/lib/ExtractAPI/APIIgnoresList.cpp b/clang/lib/ExtractAPI/APIIgnoresList.cpp index d6bbc6692d2bc..92b09bc0ad0ca 100644 --- a/clang/lib/ExtractAPI/APIIgnoresList.cpp +++ b/clang/lib/ExtractAPI/APIIgnoresList.cpp @@ -21,7 +21,7 @@ using namespace clang; using namespace clang::extractapi; using namespace llvm; -char IgnoresFileNotFound::ID; +const char IgnoresFileNotFound::ID = 0; void IgnoresFileNotFound::log(llvm::raw_ostream &os) const { os << "Could not find API ignores file " << Path; diff --git a/clang/lib/Frontend/TestModuleFileExtension.cpp b/clang/lib/Frontend/TestModuleFileExtension.cpp index 5e116702096b8..f9dfdb0105c45 100644 --- a/clang/lib/Frontend/TestModuleFileExtension.cpp +++ b/clang/lib/Frontend/TestModuleFileExtension.cpp @@ -14,7 +14,7 @@ using namespace clang; using namespace clang::serialization; -char TestModuleFileExtension::ID = 0; +const char TestModuleFileExtension::ID = 0; TestModuleFileExtension::Writer::~Writer() { } diff --git a/clang/lib/Frontend/TestModuleFileExtension.h b/clang/lib/Frontend/TestModuleFileExtension.h index e22c87ed2d1b5..0ca1682cffd27 100644 --- a/clang/lib/Frontend/TestModuleFileExtension.h +++ b/clang/lib/Frontend/TestModuleFileExtension.h @@ -44,7 +44,7 @@ class TestModuleFileExtension }; public: - static char ID; + static const char ID; TestModuleFileExtension(StringRef BlockName, unsigned MajorVersion, unsigned MinorVersion, bool Hashed, diff --git a/clang/lib/Sema/MultiplexExternalSemaSource.cpp b/clang/lib/Sema/MultiplexExternalSemaSource.cpp index 1f040c879d724..db7a294a92db9 100644 --- a/clang/lib/Sema/MultiplexExternalSemaSource.cpp +++ b/clang/lib/Sema/MultiplexExternalSemaSource.cpp @@ -14,7 +14,7 @@ using namespace clang; -char MultiplexExternalSemaSource::ID; +const char MultiplexExternalSemaSource::ID = 0; /// Constructs a new multiplexing external sema source and appends the /// given element to it. diff --git a/clang/lib/Sema/Sema.cpp b/clang/lib/Sema/Sema.cpp index d53527af38653..d4a4bb11c2d36 100644 --- a/clang/lib/Sema/Sema.cpp +++ b/clang/lib/Sema/Sema.cpp @@ -2628,7 +2628,7 @@ void Sema::ActOnComment(SourceRange Comment) { // Pin this vtable to this file. ExternalSemaSource::~ExternalSemaSource() {} -char ExternalSemaSource::ID; +const char ExternalSemaSource::ID = 0; void ExternalSemaSource::ReadMethodPool(Selector Sel) { } void ExternalSemaSource::updateOutOfDateSelector(Selector Sel) { } diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp index f3902d57e3d1f..5be296dc1baa2 100644 --- a/clang/lib/Serialization/ASTReader.cpp +++ b/clang/lib/Serialization/ASTReader.cpp @@ -1661,7 +1661,7 @@ void ASTReader::Error(unsigned DiagID, StringRef Arg1, StringRef Arg2, namespace { struct AlreadyReportedDiagnosticError : llvm::ErrorInfo<AlreadyReportedDiagnosticError> { - static char ID; + static const char ID; void log(raw_ostream &OS) const override { llvm_unreachable("reporting an already-reported diagnostic error"); @@ -1672,7 +1672,7 @@ struct AlreadyReportedDiagnosticError } }; -char AlreadyReportedDiagnosticError::ID = 0; +const char AlreadyReportedDiagnosticError::ID = 0; } // namespace void ASTReader::Error(llvm::Error &&Err) const { diff --git a/clang/lib/Serialization/ModuleFileExtension.cpp b/clang/lib/Serialization/ModuleFileExtension.cpp index 729529b5fca18..7dbc8faf72a0b 100644 --- a/clang/lib/Serialization/ModuleFileExtension.cpp +++ b/clang/lib/Serialization/ModuleFileExtension.cpp @@ -9,7 +9,7 @@ using namespace clang; -char ModuleFileExtension::ID = 0; +const char ModuleFileExtension::ID = 0; ModuleFileExtension::~ModuleFileExtension() {} diff --git a/clang/lib/Tooling/Core/Replacement.cpp b/clang/lib/Tooling/Core/Replacement.cpp index 10bdc223e33f2..28cc19b18a1e2 100644 --- a/clang/lib/Tooling/Core/Replacement.cpp +++ b/clang/lib/Tooling/Core/Replacement.cpp @@ -186,7 +186,7 @@ std::string ReplacementError::message() const { return Message; } -char ReplacementError::ID = 0; +const char ReplacementError::ID = 0; Replacements Replacements::getCanonicalReplacements() const { std::vector<Replacement> NewReplaces; diff --git a/clang/lib/Tooling/Transformer/Parsing.cpp b/clang/lib/Tooling/Transformer/Parsing.cpp index f7bffda6967a9..1c698193a62f7 100644 --- a/clang/lib/Tooling/Transformer/Parsing.cpp +++ b/clang/lib/Tooling/Transformer/Parsing.cpp @@ -52,7 +52,7 @@ template <typename T> using ParseFunction = ExpectedProgress<T> (*)(ParseState); class ParseError : public llvm::ErrorInfo<ParseError> { public: // Required field for all ErrorInfo derivatives. - static char ID; + static const char ID; ParseError(size_t Pos, std::string ErrorMsg, std::string InputExcerpt) : Pos(Pos), ErrorMsg(std::move(ErrorMsg)), @@ -74,7 +74,7 @@ class ParseError : public llvm::ErrorInfo<ParseError> { std::string Excerpt; }; -char ParseError::ID; +const char ParseError::ID = 0; } // namespace static const llvm::StringMap<RangeSelectorOp<std::string>> & diff --git a/clang/unittests/Frontend/CompilerInvocationTest.cpp b/clang/unittests/Frontend/CompilerInvocationTest.cpp index 64d0f4c38f11c..32a6e894484fc 100644 --- a/clang/unittests/Frontend/CompilerInvocationTest.cpp +++ b/clang/unittests/Frontend/CompilerInvocationTest.cpp @@ -967,7 +967,7 @@ TEST_F(CommandLineTest, DigraphsEnabled) { struct DummyModuleFileExtension : public llvm::RTTIExtends<DummyModuleFileExtension, ModuleFileExtension> { - static char ID; + static const char ID; ModuleFileExtensionMetadata getExtensionMetadata() const override { return {}; @@ -988,7 +988,7 @@ struct DummyModuleFileExtension } }; -char DummyModuleFileExtension::ID = 0; +const char DummyModuleFileExtension::ID = 0; TEST_F(CommandLineTest, TestModuleFileExtension) { const char *Args[] = {"-ftest-module-file-extension=first:2:1:0:first", diff --git a/compiler-rt/lib/orc/rtti.cpp b/compiler-rt/lib/orc/rtti.cpp index 5989955aca2ac..6a83721c38f80 100644 --- a/compiler-rt/lib/orc/rtti.cpp +++ b/compiler-rt/lib/orc/rtti.cpp @@ -18,7 +18,7 @@ namespace orc_rt { -char RTTIRoot::ID = 0; +const char RTTIRoot::ID = 0; void RTTIRoot::anchor() {} } // namespace orc_rt diff --git a/compiler-rt/lib/orc/rtti.h b/compiler-rt/lib/orc/rtti.h index d9d18140dcc16..6596a6b952064 100644 --- a/compiler-rt/lib/orc/rtti.h +++ b/compiler-rt/lib/orc/rtti.h @@ -21,19 +21,19 @@ // @code{.cpp} // class MyBaseClass : public RTTIExtends<MyBaseClass, RTTIRoot> { // public: -// static char ID; +// static const char ID; // virtual void foo() = 0; // }; // // class MyDerivedClass1 : public RTTIExtends<MyDerivedClass1, MyBaseClass> { // public: -// static char ID; +// static const char ID; // void foo() override {} // }; // // class MyDerivedClass2 : public RTTIExtends<MyDerivedClass2, MyBaseClass> { // public: -// static char ID; +// static const char ID; // void foo() override {} // }; // @@ -90,7 +90,7 @@ class RTTIRoot { private: virtual void anchor(); - static char ID; + static const char ID; }; /// Inheritance utility for extensible RTTI. @@ -104,12 +104,12 @@ class RTTIRoot { /// /// class MyType : public RTTIExtends<MyType, RTTIRoot> { /// public: -/// static char ID; +/// static const char ID; /// }; /// /// class MyDerivedType : public RTTIExtends<MyDerivedType, MyType> { /// public: -/// static char ID; +/// static const char ID; /// }; /// template <typename ThisT, typename ParentT> class RTTIExtends : public ParentT { @@ -118,7 +118,7 @@ template <typename ThisT, typename ParentT> class RTTIExtends : public ParentT { using ParentT::isA; using ParentT::ParentT; - static char ID; + static const char ID; static const void *classID() { return &ThisT::ID; } @@ -132,7 +132,7 @@ template <typename ThisT, typename ParentT> class RTTIExtends : public ParentT { }; template <typename ThisT, typename ParentT> -char RTTIExtends<ThisT, ParentT>::ID = 0; +const char RTTIExtends<ThisT, ParentT>::ID = 0; /// Returns true if the given value is an instance of the template type /// parameter. diff --git a/lldb/include/lldb/Expression/DiagnosticManager.h b/lldb/include/lldb/Expression/DiagnosticManager.h index c7e02d80cf750..c6969f4d0cd8a 100644 --- a/lldb/include/lldb/Expression/DiagnosticManager.h +++ b/lldb/include/lldb/Expression/DiagnosticManager.h @@ -32,7 +32,7 @@ class ExpressionError std::vector<DiagnosticDetail> m_details; public: - static char ID; + static const char ID; using llvm::ErrorInfo<ExpressionError, DiagnosticError>::ErrorInfo; ExpressionError(lldb::ExpressionResults result, std::string msg, std::vector<DiagnosticDetail> details = {}); diff --git a/lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h b/lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h index 72b9ccbf7dd0c..978edc13c4b28 100644 --- a/lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h +++ b/lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h @@ -27,7 +27,7 @@ class ExpressionTypeSystemHelper : public llvm::RTTIExtends<ExpressionTypeSystemHelper, llvm::RTTIRoot> { public: /// LLVM RTTI support - static char ID; + static const char ID; virtual ~ExpressionTypeSystemHelper() = default; }; diff --git a/lldb/include/lldb/Expression/ExpressionVariable.h b/lldb/include/lldb/Expression/ExpressionVariable.h index 68fa1c878a0e3..45f5c52245ea8 100644 --- a/lldb/include/lldb/Expression/ExpressionVariable.h +++ b/lldb/include... [truncated] `````````` </details> https://github.com/llvm/llvm-project/pull/179970 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
