================
@@ -3325,6 +3310,123 @@ static bool CheckVectorElementCount(Sema *S, QualType
PassedType,
return false;
}
+enum class SampleKind { Sample, Bias, Grad, Level, Cmp, CmpLevelZero };
+
+static bool CheckSamplingBuiltin(Sema &S, CallExpr *TheCall, SampleKind Kind) {
+ unsigned MinArgs, MaxArgs;
+ if (Kind == SampleKind::Sample) {
+ MinArgs = 3;
+ MaxArgs = 5;
+ } else if (Kind == SampleKind::Bias) {
+ MinArgs = 4;
+ MaxArgs = 6;
+ } else if (Kind == SampleKind::Grad) {
+ MinArgs = 5;
+ MaxArgs = 7;
+ } else if (Kind == SampleKind::Level) {
+ MinArgs = 4;
+ MaxArgs = 5;
+ } else if (Kind == SampleKind::Cmp) {
+ MinArgs = 4;
+ MaxArgs = 6;
+ } else {
+ assert(Kind == SampleKind::CmpLevelZero);
+ MinArgs = 4;
+ MaxArgs = 5;
+ }
+
+ if (S.checkArgCountRange(TheCall, MinArgs, MaxArgs))
+ return true;
+
+ if (CheckResourceHandle(&S, TheCall, 0,
+ [](const HLSLAttributedResourceType *ResType) {
+ return ResType->getAttrs().ResourceDimension ==
+ llvm::dxil::ResourceDimension::Unknown;
+ }))
+ return true;
+
+ if (CheckResourceHandle(&S, TheCall, 1,
+ [](const HLSLAttributedResourceType *ResType) {
+ return ResType->getAttrs().ResourceClass !=
+ llvm::hlsl::ResourceClass::Sampler;
+ }))
+ return true;
+
+ auto *ResourceTy =
+ TheCall->getArg(0)->getType()->castAs<HLSLAttributedResourceType>();
+
+ unsigned ExpectedDim =
+ getResourceDimensions(ResourceTy->getAttrs().ResourceDimension);
+ if (CheckVectorElementCount(&S, TheCall->getArg(2)->getType(),
+ S.Context.FloatTy, ExpectedDim,
+ TheCall->getBeginLoc()))
+ return true;
+
+ unsigned NextIdx = 3;
+ if (Kind == SampleKind::Bias || Kind == SampleKind::Level ||
+ Kind == SampleKind::Cmp || Kind == SampleKind::CmpLevelZero) {
+ QualType BiasOrLODOrCmpTy = TheCall->getArg(NextIdx)->getType();
+ if (!BiasOrLODOrCmpTy->isFloatingType() ||
+ BiasOrLODOrCmpTy->isVectorType()) {
+ S.Diag(TheCall->getArg(NextIdx)->getBeginLoc(),
+ diag::err_typecheck_convert_incompatible)
+ << BiasOrLODOrCmpTy << S.Context.FloatTy << 1 << 0 << 0;
+ return true;
+ }
+ NextIdx++;
+ } else if (Kind == SampleKind::Grad) {
+ if (ExpectedDim != 0) {
+ if (CheckVectorElementCount(&S, TheCall->getArg(NextIdx)->getType(),
+ S.Context.FloatTy, ExpectedDim,
+ TheCall->getArg(NextIdx)->getBeginLoc()))
+ return true;
+ if (CheckVectorElementCount(&S, TheCall->getArg(NextIdx + 1)->getType(),
+ S.Context.FloatTy, ExpectedDim,
+ TheCall->getArg(NextIdx + 1)->getBeginLoc()))
+ return true;
+ }
+ NextIdx += 2;
+ }
+
+ // Offset
+ if (TheCall->getNumArgs() > NextIdx) {
+ if (ExpectedDim != 0) {
----------------
s-perron wrote:
The is an llvm_unreachable if we cannot know the dimension. I did not add
another assert.
https://github.com/llvm/llvm-project/pull/179322
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
