================
@@ -292,26 +355,77 @@ def check_notes(self, clang_tidy_output: str) -> None:
try_run(
[
"FileCheck",
- "-input-file=" + notes_file,
+ f"-input-file={notes_file}",
self.input_file_name,
- "-check-prefixes=" + ",".join(self.notes.prefixes),
+ f"-check-prefixes={','.join(self.notes.prefixes)}",
"-implicit-check-not={{note|warning|error}}:",
]
)
+ def check_header_messages(self, clang_tidy_output: str) -> str:
+ """
+ Filters and verifies clang-tidy diagnostics for headers.
----------------
vbvictor wrote:
I think we can split this function into 2:
1)new function to separate messages/fixes in headers and main file
2)extract call of "self.check_messages" into the same place as
```python
elif self.export_fixes is None:
# ...code
for temp_header, original_header in self.check_header_map.items():
self.check_fixes(
```
I can see we loop over the same values of `self.check_header_map.items()` in
two different places and I suspect we can do it in one place.
Or I'm missing some bigger picture why we can't do that and have to make 2
separate loops.
https://github.com/llvm/llvm-project/pull/175735
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
