llvmbot wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Jordan Rupprecht (rupprecht)

<details>
<summary>Changes</summary>

Using `-fopenmp` uses the default openmp lib, which defaults to `libomp` but 
may be something else. This test only passes with `libomp`, so it passes when 
using all defaults, but fails downstream if configured for something else, like 
`libgomp`.

---
Full diff: https://github.com/llvm/llvm-project/pull/180221.diff


1 Files Affected:

- (modified) clang/test/Driver/openmp-target-fast-flag.c (+7-7) 


``````````diff
diff --git a/clang/test/Driver/openmp-target-fast-flag.c 
b/clang/test/Driver/openmp-target-fast-flag.c
index 4ded4be341801..0390790b3f533 100644
--- a/clang/test/Driver/openmp-target-fast-flag.c
+++ b/clang/test/Driver/openmp-target-fast-flag.c
@@ -1,24 +1,24 @@
 // REQUIRES: x86-registered-target, amdgpu-registered-target
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib %s -O0 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib %s -O0 2>&1 \
 // RUN:   | FileCheck 
-check-prefixes=DefaultTFast,DefaultTState,DefaultNoNestParallel %s
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O0 
-fopenmp-target-fast %s 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O0 
-fopenmp-target-fast %s 2>&1 \
 // RUN:   | FileCheck -check-prefixes=TState,NestParallel %s
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O3 %s 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O3 %s 2>&1 \
 // RUN:   | FileCheck 
-check-prefixes=O3,DefaultTFast,DefaultTState,DefaultNoNestParallel %s
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O3 
-fno-openmp-target-fast %s 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O3 
-fno-openmp-target-fast %s 2>&1 \
 // RUN:   | FileCheck -check-prefixes=O3,DefaultTState,DefaultNoNestParallel %s
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -Ofast %s 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -Ofast %s 2>&1 \
 // RUN:   | FileCheck -check-prefixes=OFast,TState,NestParallel %s
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -Ofast 
-fno-openmp-target-fast %s 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -Ofast 
-fno-openmp-target-fast %s 2>&1 \
 // RUN:   | FileCheck 
-check-prefixes=OFast,DefaultTState,DefaultNoNestParallel %s
 
-// RUN:   %clang -### -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O0 
-fno-openmp-target-fast -fopenmp-target-fast %s 2>&1 \
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa 
-Xopenmp-target=amdgcn-amd-amdhsa -march=gfx90a -nogpulib -O0 
-fno-openmp-target-fast -fopenmp-target-fast %s 2>&1 \
 // RUN:   | FileCheck -check-prefixes=TState,NestParallel %s
 
 // O3: -O3

``````````

</details>


https://github.com/llvm/llvm-project/pull/180221
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to