Author: Florian Mayer Date: 2026-02-06T12:53:49-08:00 New Revision: b5b453d0dfb013de0275ae5bf704df943759e627
URL: https://github.com/llvm/llvm-project/commit/b5b453d0dfb013de0275ae5bf704df943759e627 DIFF: https://github.com/llvm/llvm-project/commit/b5b453d0dfb013de0275ae5bf704df943759e627.diff LOG: [NFC] [FlowSensitive] [StatusOr] add more tests for gtest macros Reviewers: jvoung Pull Request: https://github.com/llvm/llvm-project/pull/180072 Added: Modified: clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp Removed: ################################################################################ diff --git a/clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp b/clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp index fd0c6f13c0031..41505dd720ef7 100644 --- a/clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp +++ b/clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp @@ -2355,6 +2355,63 @@ TEST_P(UncheckedStatusOrAccessModelTest, AssertTrueMacro) { )cc"); } +TEST_P(UncheckedStatusOrAccessModelTest, ExpectTrueMacro) { + ExpectDiagnosticsFor(R"cc( +#include "unchecked_statusor_access_test_defs.h" + + void target(STATUSOR_INT sor) { + EXPECT_TRUE(sor.ok()); + + sor.value(); // [[unsafe]] + } + )cc"); + ExpectDiagnosticsFor(R"cc( +#include "unchecked_statusor_access_test_defs.h" + + void target(STATUSOR_INT sor) { + EXPECT_TRUE(sor.status().ok()); + + sor.value(); // [[unsafe]] + } + )cc"); + ExpectDiagnosticsFor(R"cc( +#include "unchecked_statusor_access_test_defs.h" + + void target(STATUSOR_INT sor) { + EXPECT_TRUE(!sor.ok()); + + sor.value(); // [[unsafe]] + } + )cc"); +} + +TEST_P(UncheckedStatusOrAccessModelTest, AssertFalseMacro) { + ExpectDiagnosticsFor(R"cc( +#include "unchecked_statusor_access_test_defs.h" + + void target(STATUSOR_INT sor) { + ASSERT_FALSE(!sor.ok()); + sor.value(); + } + )cc"); + ExpectDiagnosticsFor(R"cc( +#include "unchecked_statusor_access_test_defs.h" + + void target(STATUSOR_INT sor) { + ASSERT_FALSE(!sor.status().ok()); + sor.value(); + } + )cc"); + ExpectDiagnosticsFor(R"cc( +#include "unchecked_statusor_access_test_defs.h" + + void target(STATUSOR_INT sor) { + ASSERT_FALSE(sor.ok()); + sor.value(); // [[unsafe]] + } + )cc"); +} + TEST_P(UncheckedStatusOrAccessModelTest, AssertOkMacro) { ExpectDiagnosticsFor(R"cc( #include "unchecked_statusor_access_test_defs.h" _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
