================
@@ -0,0 +1,118 @@
+//===--- UseStdMoveCheck.cpp - clang-tidy
---------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseStdMoveCheck.h"
+
+#include "../utils/DeclRefExprUtils.h"
+
+#include "clang/AST/Expr.h"
+#include "clang/AST/ExprCXX.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
+#include "clang/Lex/Lexer.h"
+#include "llvm/ADT/STLExtras.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::performance {
+
+namespace {
+AST_MATCHER(CXXRecordDecl, hasTrivialMoveAssignment) {
+ return Node.hasTrivialMoveAssignment();
+}
+
+AST_MATCHER(VarDecl, isMovableAndProfitable) {
+ const QualType NodeQual = Node.getType();
+
+ // Not profitable.
+ if (NodeQual->isScalarType())
+ return false;
+
+ // Not valid.
+ if (NodeQual->isLValueReferenceType() || NodeQual.isConstQualified())
+ return false;
+
+ return true;
+}
----------------
vbvictor wrote:
We should be able to do something like:
```cpp
AST_MATCHER(QualType, isScalarType) {
return Node.isScalarType();
}
AST_MATCHER(QualType, isLValueReferenceType) {
return Node.isLValueReferenceType();
}
// registerMatchers
varDecl(hasLocalStorage(),
hasType(qualType(
unless(anyOf(
isScalarType(), // Not profitable.
isLValueReferenceType(), isConstQualified()
))
)))
```
Eventually we should transfer all custom `AST_MATCHER` to main library as
building blocks. (But it's out of scope for this PR ofc)
https://github.com/llvm/llvm-project/pull/179467
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
