arsenm wrote:

> > Should restrict this to just adding the basic pass, without the fancy 
> > assumed address space or assume handling. Leave those for later.
> 
> Any particular reason for this, asides from the concern around **constant** / 
> UniformConstant? I'll re-iterate that for AMDGCN flavoured SPIR-V it should 
> do exactly what we do in AMDGPU, so punting in general seems 
> counter-intuitive.

Patch splitting and test coverage concern that goes beyond what's in the title 

InferAddressSpaces should be enabled for SPIRV 

https://github.com/llvm/llvm-project/pull/110897
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to