vbvictor wrote: > I can split into two patches if you prefer, though keeping it in one PR keeps > the review focused on a single end-to-end change and avoids churn from moving > code around separately.
It will be much better if you split this. Lexer patch will be NFC which is failry easy to review and it needs less attention that the bugfix. And if something goes wrong with the bugfix, we can revert only the patch that broke buildbots without touching NFC lexer changes. https://github.com/llvm/llvm-project/pull/180366 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
