unterumarmung wrote: > We should warn on both or neither.
Probably it should not warn when the type is explicitly typed. > Also, do we want to put this new behaviour behind an option? (general > question to other reviewers) I’m new to clang-tidy, so I may be missing context, but my view is that this probably shouldn’t be gated behind a new option. The check’s goal is to clarify ambiguous arguments, and braced-init arguments are among the least self-describing forms at the call site. Since users already opt in to literal-commenting via existing options, adding another switch increases configuration surface without a strong use case. Making this behavior unconditional seems aligned with the check’s intent and keeps configuration simpler. If compatibility concerns exist, an option could be added, but I’d still lean toward default-on. https://github.com/llvm/llvm-project/pull/180408 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
